Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c24c921ec82545ac94b5a03ef909e761a92849e6
https://github.com/WebKit/WebKit/commit/c24c921ec82545ac94b5a03ef909e761a92849e6
Author: Wenson Hsieh <[email protected]>
Date: 2025-05-31 (Sat, 31 May 2025)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ObscuredContentInsets.mm
Log Message:
-----------
[macOS] Content inset fill capture color sometimes fails to update when the
page background changes
https://bugs.webkit.org/show_bug.cgi?id=293857
rdar://152108302
Reviewed by Abrar Rahman Protyasha.
Ensure that the content inset fill view capture color does not become stale in
the case where only
the page background color changes.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateTopContentInsetFillCaptureColor]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::underPageBackgroundColorDidChange):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::pageDidScroll):
(WebKit::WebViewImpl::updateTopContentInsetFillCaptureColor):
Move logic to update the content inset fill view's capture color out into a
helper method, so we can
call it when the page background color changes.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ObscuredContentInsets.mm:
(TestWebKitAPI::TEST(ObscuredContentInsets, ContentInsetFillCaptureColor)):
Add an API test to exercise this change, by validating that the capture color
changes when the page
background color changes.
Canonical link: https://commits.webkit.org/295658@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
