Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4923841d8c930238c18627cdd55ddee11490828d
https://github.com/WebKit/WebKit/commit/4923841d8c930238c18627cdd55ddee11490828d
Author: Ahmad Saleem <[email protected]>
Date: 2025-06-01 (Sun, 01 Jun 2025)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/platform/gtk/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt
M LayoutTests/platform/ios/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt
M LayoutTests/platform/win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt
M LayoutTests/platform/wpe/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt
M Source/WebCore/svg/properties/SVGAnimationDiscreteFunction.h
Log Message:
-----------
Fix switch-over point for implicit discrete 'to'-animations
https://bugs.webkit.org/show_bug.cgi?id=293862
rdar://problem/152376446
Reviewed by Simon Fraser.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
Merge:
https://source.chromium.org/chromium/chromium/src/+/39d072be004bf3fc4a5f534c0d926293255ec74f
SMIL Animation (3.2.3) [1] says:
"For the shorthand form to animation, there is only 1 value; a discrete
to animation will simply set the "to" value for the simple duration."
SVG Animation (2.10) [2] says:
"...the behavior of discrete to-animation in SVG deviates from the
definition in SMIL Animation. As with a discrete from-to animation, a
discrete to animation will set the underlying value for the first half
of the simple duration ... and the ‘to’ value for the remainder of the
simple duration."
For calcMode != "discrete" and non-interpolable types we were
implementing the former and not the latter. This patch changes it.
[1] https://www.w3.org/TR/2001/REC-smil-animation-20010904/
[2] https://svgwg.org/specs/animations/#ValueAttributes
* Source/WebCore/svg/properties/SVGAnimationDiscreteFunction.h:
(WebCore::SVGAnimationDiscreteFunction::animate):
* LayoutTests/TestExpectations: WPT progression
* LayoutTests/platform/gtk/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
Matches other browser
* LayoutTests/platform/ios/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Ditto
* LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Ditto
* LayoutTests/platform/win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Ditto
* LayoutTests/platform/wpe/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Ditto
Canonical link: https://commits.webkit.org/295662@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
