Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 304d438ce4cad47f7fa81a54428668aad842f24b
https://github.com/WebKit/WebKit/commit/304d438ce4cad47f7fa81a54428668aad842f24b
Author: Alex Christensen <[email protected]>
Date: 2025-06-02 (Mon, 02 Jun 2025)
Changed paths:
M Source/WebCore/editing/cocoa/DictionaryLookup.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
Fix nullptr crashes when clicking on site isolated iframes after 295636@main
https://bugs.webkit.org/show_bug.cgi?id=293916
rdar://152448845
Reviewed by Megan Gardner and Tim Horton.
295636@main introduced 2 places where we derefernce a text indicator before
checking if it's null.
I hit crashes when browsing the web. Let's check for null and not crash.
* Source/WebCore/editing/cocoa/DictionaryLookup.mm:
(WebCore::showPopupOrCreateAnimationController):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::remoteDictionaryPopupInfoToRootView):
Canonical link: https://commits.webkit.org/295707@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
