Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 47e9d9c342253956e9f0c87baadc60aa45d4c7b7
https://github.com/WebKit/WebKit/commit/47e9d9c342253956e9f0c87baadc60aa45d4c7b7
Author: Anne van Kesteren <[email protected]>
Date: 2025-06-02 (Mon, 02 Jun 2025)
Changed paths:
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/html/BaseButtonInputType.cpp
M Source/WebCore/html/BaseDateAndTimeInputType.cpp
M Source/WebCore/html/DateInputType.cpp
M Source/WebCore/html/DateTimeLocalInputType.cpp
M Source/WebCore/html/FileInputType.cpp
M Source/WebCore/html/ImageInputType.cpp
M Source/WebCore/html/InputType.cpp
M Source/WebCore/html/MonthInputType.cpp
M Source/WebCore/html/NumberInputType.cpp
M Source/WebCore/html/RangeInputType.cpp
M Source/WebCore/html/SearchInputType.cpp
M Source/WebCore/html/TextFieldInputType.cpp
M Source/WebCore/html/TimeInputType.cpp
M Source/WebCore/html/WeekInputType.cpp
Log Message:
-----------
Reduce unsafeness in InputType classes even more
https://bugs.webkit.org/show_bug.cgi?id=293852
rdar://152359661
Reviewed by Chris Dumez.
Apply https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines once
again as new issues have surfaced.
An interesting realization I had is that it's very useful when the
variable is named after the local member. A couple of files used
Ref input = *element();
instead, but this has the side effect of a) it being possible to miss
element() calls, and b) when someone then goes to fix those element()
calls they might miss that there's an input variable and write
protectedElement() instead. Hence this patch aligns on
Ref element = *this->element();
Canonical link: https://commits.webkit.org/295719@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
