Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 73dbb82c87fa7f9abbb61e6c4c7906c418684772
https://github.com/WebKit/WebKit/commit/73dbb82c87fa7f9abbb61e6c4c7906c418684772
Author: Megan Gardner <[email protected]>
Date: 2025-06-03 (Tue, 03 Jun 2025)
Changed paths:
M Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Log Message:
-----------
REGRESSION(295633@main-295637@main): Broke
TestWebKitAPI.ActionSheetTests.DataDetectorsLinkIsNotPresentedAsALink
https://bugs.webkit.org/show_bug.cgi?id=293968
rdar://152449697
Reviewed by Abrar Rahman Protyasha.
When I made a bunch of changes to use TextIndicator instead
of TextIndicatorData I didn't do enough null checks to keep
things working properly. This should fix those issues.
* Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant
contextMenuInteraction:configurationForMenuAtLocation:]):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dataDetectionContextForPositionInformation:]):
(-[WKContentView _createTargetedContextMenuHintPreviewIfPossible]):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::linkIndicatorPositionInformation):
(WebKit::WebPage::positionInformation):
Canonical link: https://commits.webkit.org/295779@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes