Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 80ff32d5e1aedf822c3117464e01d85d9cf7214e
https://github.com/WebKit/WebKit/commit/80ff32d5e1aedf822c3117464e01d85d9cf7214e
Author: Lauro Moura <[email protected]>
Date: 2025-06-03 (Tue, 03 Jun 2025)
Changed paths:
M Source/WebDriver/Session.cpp
M Source/WebDriver/WebDriverService.cpp
Log Message:
-----------
[WebDriver] Driver segfault when a pointer move or scroll action is missing a
coordinate
https://bugs.webkit.org/show_bug.cgi?id=293703
Reviewed by BJ Burg.
Both pointerMove and scroll actions require the presence of the x and y
coordinates, alongside deltaX and deltaY for the latter.
This commit ensures we check for their presence when processing the
incoming actions, alongside validating the coordinate presence before
actually sending the actions to the browser as an extra blanket.
We also add extra checks as the scroll coordinates must be integers,
while pointer move recently started allowing fractional coordinates.
Lastly, this commit fixes some typos in the actions error messages,
also rephrasing for clarity and uniformity.
* Source/WebDriver/Session.cpp:
(WebDriver::Session::performActions):
* Source/WebDriver/WebDriverService.cpp:
(WebDriver::processPauseAction):
(WebDriver::processNullAction):
(WebDriver::processKeyAction):
(WebDriver::processPointerMoveAction):
(WebDriver::processPointerAction):
(WebDriver::processWheelAction):
(WebDriver::processPointerParameters):
(WebDriver::processInputActionSequence):
(WebDriver::WebDriverService::performActions):
Canonical link: https://commits.webkit.org/295789@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
