Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 56f70884724fb1a8ca99e5e2d043aa3016c5baf3
https://github.com/WebKit/WebKit/commit/56f70884724fb1a8ca99e5e2d043aa3016c5baf3
Author: Chris Dumez <[email protected]>
Date: 2025-06-03 (Tue, 03 Jun 2025)
Changed paths:
M Source/JavaScriptCore/jsc.cpp
M Source/WTF/wtf/StreamBuffer.h
M Source/WTF/wtf/cocoa/SpanCocoa.h
M Source/WebCore/page/ios/FrameIOS.mm
M Source/WebCore/platform/graphics/GCGLSpan.h
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
M Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm
M
Source/WebKit/Platform/classifier/cocoa/ResourceLoadStatisticsClassifierCocoa.cpp
M Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm
M Source/WebKit/Shared/Cocoa/CoreIPCCFURL.mm
M Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm
M Source/WebKit/Shared/Extensions/WebExtensionUtilities.cpp
M Source/WebKit/Shared/RTCNetwork.cpp
M Source/WebKit/Shared/cf/CookieStorageUtilsCF.mm
M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
M Source/WebKit/UIProcess/API/C/WKPage.cpp
M Source/WebKit/UIProcess/API/Cocoa/_WKTouchEventGenerator.mm
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidConnection.mm
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
M
Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorUtils.mm
M Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp
M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm
M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
M Source/WebKitLegacy/WebCoreSupport/SocketStreamHandleImpl.cpp
M Source/WebKitLegacy/WebCoreSupport/WebSocketChannel.cpp
M Source/WebKitLegacy/mac/Misc/WebKitNSStringExtras.mm
M Source/WebKitLegacy/mac/Plugins/WebBasePluginPackage.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebVisitedLinkStore.mm
M Source/WebKitLegacy/mac/WebView/WebTextIterator.mm
M Tools/DumpRenderTree/PixelDumpSupport.cpp
M Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
M Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
M Tools/TestWebKitAPI/NetworkConnection.mm
M Tools/TestWebKitAPI/Tests/IPC/ArgumentCoderTests.cpp
M Tools/TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp
M Tools/TestWebKitAPI/Tests/WTF/StdLibExtrasTests.cpp
M Tools/TestWebKitAPI/Tests/WTF/StringCommon.cpp
M Tools/TestWebKitAPI/Tests/WTF/StringHasher.cpp
M Tools/TestWebKitAPI/Tests/WTF/Vector.cpp
M Tools/TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp
M Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp
M Tools/TestWebKitAPI/Tests/WebCore/RTCRtpSFrameTransformerTests.cpp
M Tools/TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/CookieAcceptPolicy.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm
M Tools/TestWebKitAPI/cocoa/DaemonTestUtilities.mm
M Tools/TestWebKitAPI/cocoa/HTTPServer.mm
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
M Tools/WebKitTestRunner/PixelDumpSupport.cpp
M Tools/WebKitTestRunner/ios/HIDEventGenerator.mm
Log Message:
-----------
Further reduce use of Vector::data() in the codebase
https://bugs.webkit.org/show_bug.cgi?id=293934
Reviewed by Justin Michaud.
Further reduce use of Vector::data() in the codebase, in favor of using
Vector::span(). This is a step towards dropping Vector::data() and encouraging
developers to use spans.
* Source/JavaScriptCore/jsc.cpp:
(currentWorkingDirectory):
(fillBufferWithContentsOfFile):
(JSC_DEFINE_HOST_FUNCTION):
* Source/WTF/wtf/StreamBuffer.h:
(WTF::StreamBuffer::firstBlockData const):
* Source/WTF/wtf/Vector.h:
* Source/WTF/wtf/cocoa/SpanCocoa.h:
* Source/WebCore/platform/graphics/GCGLSpan.h:
* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::multiDrawElementsANGLE):
(WebKit::RemoteGraphicsContextGL::multiDrawElementsInstancedANGLE):
(WebKit::RemoteGraphicsContextGL::multiDrawElementsInstancedBaseVertexBaseInstanceANGLE):
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::setProxyConfigData):
* Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm:
(IPC::readFromMachPort):
*
Source/WebKit/Platform/classifier/cocoa/ResourceLoadStatisticsClassifierCocoa.cpp:
(WebKit::ResourceLoadStatisticsClassifierCocoa::classify):
* Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::toPKContactFields):
* Source/WebKit/Shared/Cocoa/CoreIPCCFURL.mm:
(WebKit::CoreIPCCFURL::createWithBaseURLAndBytes):
(WebKit::CoreIPCCFURL::toVector const):
* Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtension::createHandleForTemporaryFile):
* Source/WebKit/Shared/Extensions/WebExtensionUtilities.cpp:
(WebKit::formatString):
* Source/WebKit/Shared/RTCNetwork.cpp:
(WebKit::RTCNetwork::value const):
(WebKit::RTC::Network::SocketAddress::rtcAddress const):
* Source/WebKit/Shared/cf/CookieStorageUtilsCF.mm:
(WebKit::cookieStorageFromIdentifyingData):
* Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::compileAndApplySandboxSlowCase):
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageComputePagesForPrinting):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidConnection.mm:
(WebKit::HidConnection::initialize):
(WebKit::HidConnection::terminate):
(WebKit::HidConnection::sendSync):
(WebKit::HidConnection::send):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):
*
Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorUtils.mm:
(WebKit::credentialIdAndCosePubKeyForPrivateKey):
(WebKit::signatureForPrivateKey):
* Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::createDictionary):
* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::toJSArray):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp:
(WebKit::WebGPU::RemoteBufferProxy::getMappedRange):
* Source/WebKit/WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm:
(-[WKDOMTextIterator currentTextPointer]):
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm:
(WebKit::createPlatformDataDetectorHighlight):
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSIPC::serializedEnumInfo):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::setVideoDecoderBehaviors):
* Source/WebKitLegacy/WebCoreSupport/SocketStreamHandleImpl.cpp:
(WebCore::SocketStreamHandleImpl::platformSendHandshake):
* Source/WebKitLegacy/WebCoreSupport/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::processFrame):
* Source/WebKitLegacy/mac/Misc/WebKitNSStringExtras.mm:
(-[NSString _web_drawAtPoint:font:textColor:]):
(-[NSString _web_widthWithFont:]):
* Source/WebKitLegacy/mac/Plugins/WebBasePluginPackage.mm:
(swapIntsInHeader):
(-[WebBasePluginPackage isNativeLibraryData:]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebVisitedLinkStore.mm:
(WebVisitedLinkStore::addVisitedLink):
* Source/WebKitLegacy/mac/WebView/WebTextIterator.mm:
(-[WebTextIterator currentTextPointer]):
* Tools/DumpRenderTree/PixelDumpSupport.cpp:
(printPNG):
* Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(concatenateAttributeAndValue):
* Tools/TestWebKitAPI/NetworkConnection.mm:
(TestWebKitAPI::Connection::receiveHTTPRequest const):
(TestWebKitAPI::Connection::webSocketHandshake):
* Tools/TestWebKitAPI/Tests/IPC/ArgumentCoderTests.cpp:
(TestWebKitAPI::ArgumentCoderEncoderDecoderTest<IPC::StreamConnectionEncoder>::createDecoder
const):
* Tools/TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
(testBoundaries):
(testNumbers):
* Tools/TestWebKitAPI/Tests/WTF/StdLibExtrasTests.cpp:
(TestWebKitAPI::TEST(WTF_StdLibExtras, SpanReinterpretCast_NonDynamicExtent)):
* Tools/TestWebKitAPI/Tests/WTF/StringCommon.cpp:
(TestWebKitAPI::TEST(WTF_StringCommon, Find8NonASCII)):
(TestWebKitAPI::TEST(WTF_StringCommon, Find16NonASCII)):
* Tools/TestWebKitAPI/Tests/WTF/StringHasher.cpp:
(TestWebKitAPI::TEST(WTF, StringHasher_SuperFastHash_VS_WYHash)):
* Tools/TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST(WTF_Vector, Basic)):
(TestWebKitAPI::TEST(WTF_Vector, ZeroSize)):
* Tools/TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
(TestWebKitAPI::eq):
(TestWebKitAPI::TEST(CBORWriterTest, TestWriteArray)):
(TestWebKitAPI::TEST(CBORWriterTest, TestWriteMapWithMapValue)):
(TestWebKitAPI::TEST(CBORWriterTest, TestWriteMapWithArray)):
(TestWebKitAPI::TEST(CBORWriterTest, TestWriteNestedMap)):
* Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::TEST_F(ContentExtensionTest,
SearchSuffixesWithIdenticalActionAreMerged)):
(TestWebKitAPI::TEST_F(ContentExtensionTest,
SearchSuffixesWithDistinguishableActionAreNotMerged)):
(TestWebKitAPI::TEST_F(ContentExtensionTest,
UselessTermsMatchingEverythingAreEliminated)):
(TestWebKitAPI::TEST_F(ContentExtensionTest, SplittingLargeNFAs)):
(TestWebKitAPI::TEST_F(ContentExtensionTest, Serialization)):
* Tools/TestWebKitAPI/Tests/WebCore/RTCRtpSFrameTransformerTests.cpp:
(TestWebKitAPI::TEST(RTCRtpSFrameTransformer, EncryptDecrypt)):
(TestWebKitAPI::TEST(RTCRtpSFrameTransformer, EncryptDecryptKeyID0)):
(TestWebKitAPI::TEST(RTCRtpSFrameTransformer, EncryptDecryptAudio)):
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm:
(TestWebKitAPI::TEST(PrivateClickMeasurement, ValidBlindedSecret)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
(testCertificate):
(createTestIdentity):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CookieAcceptPolicy.mm:
(TEST(WKHTTPCookieStore, CookiePolicy)):
(TEST(WKHTTPCookieStore, CookiePolicyAllowIsOnlyFromMainDocumentDomain)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(downloadTestServer):
(TestWebKitAPI::ResumeWithoutInitialDataOnDisk)):
(TestWebKitAPI::ResumeWithExtraInitialDataOnDisk)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:
(TestWebKitAPI::runBasicPCMTest):
(TestWebKitAPI::triggerAttributionWithSubresourceRedirect):
(TestWebKitAPI::signUnlinkableTokenAndSendSecretToken):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
(TEST(WKWebView, LoadHTMLStringOrigin)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
(TEST(WebKit, HTTPReferer)):
(TEST(NetworkProcess, CORSPreflightCachePartitioned)):
(TEST(_WKDataTask, Basic)):
(TEST(WKWebView, CrossOriginDoubleRedirectAuthentication)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
(TestWebKitAPI::TEST(WebKit, RelaxThirdPartyCookieBlocking)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm:
(TestWebKitAPI::TEST(SOAuthorizationRedirect,
InterceptionSucceedWith307Simple)):
(TestWebKitAPI::TEST(SOAuthorizationRedirect,
InterceptionSucceedWith307CrossOrigin)):
(TestWebKitAPI::TEST(SOAuthorizationRedirect, InterceptionFailedWith307PUT)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
((ServiceWorkers, ContentRuleList)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::printTree):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm:
(TEST(WebKit, UploadDirectory)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
(TEST_F(WKContentRuleListStoreTest, CrossOriginCookieBlocking)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
(TEST(WKHTTPCookieStore, WebSocketCookies)):
(TEST(WKHTTPCookieStore, WebSocketCookiesFromRedirect)):
(TEST(WKHTTPCookieStore, WebSocketCookiesThroughRedirect)):
(TEST(WKHTTPCookieStore, WebSocketSetCookiesThroughFirstPartyRedirect)):
(TEST(WKHTTPCookieStore, WebSocketSetCookiesThroughRedirectToThirdParty)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
((WebKit, OriginHeaderWithCORSDisablingPatternsInUnrelatedWebView)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
(TEST(WebKit, ConfigurationHTTPSUpgrade)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
(TestWebKitAPI::(WKWebsiteDataStore, ClearCustomDataStoreNoWebViews)):
* Tools/TestWebKitAPI/cocoa/DaemonTestUtilities.mm:
(TestWebKitAPI::currentExecutableLocation):
* Tools/TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::HTTPServer::parsePath):
(TestWebKitAPI::HTTPServer::parseBody):
(TestWebKitAPI::H2::Connection::receive const):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::createWKDictionary):
(WTR::captureDeviceProperties):
* Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::concatenateAttributeAndValue):
* Tools/WebKitTestRunner/PixelDumpSupport.cpp:
(printPNG):
Canonical link: https://commits.webkit.org/295795@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
