Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f63d69092df25f7d58a373a8a59bd06af23ce987
https://github.com/WebKit/WebKit/commit/f63d69092df25f7d58a373a8a59bd06af23ce987
Author: Yusuke Suzuki <[email protected]>
Date: 2025-06-05 (Thu, 05 Jun 2025)
Changed paths:
A JSTests/wasm/stress/resources/wasm-gc-ref-cast.wasm
A JSTests/wasm/stress/resources/wasm-gc-ref-cast.wat
A JSTests/wasm/stress/wasm-gc-ref-cast.mjs
M Source/JavaScriptCore/wasm/WasmFormat.h
M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp
M Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp
Log Message:
-----------
Js/Wasm engine produce an invalid ref.cast runtime fail for func.ref types in
hot functions.
https://bugs.webkit.org/show_bug.cgi?id=293113
rdar://151464447
Reviewed by Daniel Liu and Keith Miller.
274558@main changed rtt field of WasmToWasmImportableFunction from
CompactPtr to normal pointer, but it didn't change OMG code generator's
loadCompactPtr. So we are materializing a pointer incorrectly. This
patch removes loadCompactPtr and use normal Load for OMG.
* JSTests/wasm/stress/resources/wasm-gc-ref-cast.wasm: Added.
* JSTests/wasm/stress/resources/wasm-gc-ref-cast.wat: Added.
* JSTests/wasm/stress/wasm-gc-ref-cast.mjs: Added.
* Source/JavaScriptCore/wasm/WasmFormat.h:
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp:
(JSC::Wasm::OMGIRGenerator::emitLoadRTTFromFuncref):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp:
(JSC::Wasm::OMGIRGenerator::emitLoadRTTFromFuncref):
Canonical link: https://commits.webkit.org/295902@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
