Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: facc836f8c3e67d3fdde0cca9170428203d21abd
https://github.com/WebKit/WebKit/commit/facc836f8c3e67d3fdde0cca9170428203d21abd
Author: Youenn Fablet <[email protected]>
Date: 2025-06-06 (Fri, 06 Jun 2025)
Changed paths:
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h
Log Message:
-----------
Disable nw-based monitoring of interface by default
https://bugs.webkit.org/show_bug.cgi?id=294114
rdar://152271504
Reviewed by Chris Dumez.
Add a feature flag to enable or disable nw-based monitoring of interfaces.
Update the compilation directives to compile the timer based support of
interface monitoring and use this when the flag is disabled.
We put the feature flag as false by default since it triggered a regression on
VisionOS.
We do some additional refactoring:
- We recreate the nw_monitoring everytime we restart the interface monitoring
- We add some more logging in NetworkManagerWrapper.
- We try stopping the interface monitoring if a NetworkRTCMonitor is destroyed
without being stopped.
- We update NetworkRTCMonitor::m_isStarted to be only available in
ASSERT_ENABLED since it is only used for asserts.
- We rename NetworkManager to NetworkRTCSharedMonitor as it better captures
what this is.
* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::createNWPathMonitor):
(WebKit::NetworkManager::NetworkManager):
(WebKit::NetworkManager::addListener):
(WebKit::NetworkManager::removeListener):
(WebKit::NetworkManager::adapterTypeFromInterfaceName const):
(WebKit::NetworkManager::updateNetworksFromPath):
(WebKit::NetworkRTCMonitor::~NetworkRTCMonitor):
(WebKit::NetworkRTCMonitor::startUpdatingIfNeeded):
(WebKit::NetworkRTCMonitor::stopUpdating):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.h:
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::webRTCInterfaceMonitoringViaNWEnabled const):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h:
Canonical link: https://commits.webkit.org/295942@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
