Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d69f4715b015bb45ab9a045d3c778c592397edac
https://github.com/WebKit/WebKit/commit/d69f4715b015bb45ab9a045d3c778c592397edac
Author: Simon Fraser <simon.fra...@apple.com>
Date: 2025-06-08 (Sun, 08 Jun 2025)
Changed paths:
M LayoutTests/fast/box-shadow/shadow-box-resize-writing-mode-expected.txt
A
LayoutTests/fast/repaint/box-shadow-repaint-sideways-writing-modes-expected.txt
A LayoutTests/fast/repaint/box-shadow-repaint-sideways-writing-modes.html
A LayoutTests/fast/repaint/box-shadow-repaint-writing-modes-expected.txt
A LayoutTests/fast/repaint/box-shadow-repaint-writing-modes.html
M Source/WebCore/rendering/RenderBox.cpp
Log Message:
-----------
Box-shadow repaint is broken in some writing modes
https://bugs.webkit.org/show_bug.cgi?id=294179
rdar://152803240
Reviewed by Alan Baradlay.
Visual overflow is in the block's coordinate space (see the comment in
`RenderBox::allowedLayoutOverflow()`),
so overflow from box-shadow (and the other contributors like border-image) need
to handle that.
* LayoutTests/fast/box-shadow/shadow-box-resize-writing-mode-expected.txt:
Progression; the test is also visibly progressed.
*
LayoutTests/fast/repaint/box-shadow-repaint-sideways-writing-modes-expected.txt:
Added.
* LayoutTests/fast/repaint/box-shadow-repaint-sideways-writing-modes.html:
Added.
* LayoutTests/fast/repaint/box-shadow-repaint-writing-modes-expected.txt: Added.
* LayoutTests/fast/repaint/box-shadow-repaint-writing-modes.html: Added.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::shadowOutsetsForWritingMode): Handle the confusing negative top/left
that box-shadow outsets use,
and flip along the block axis if necessary.
(WebCore::RenderBox::applyVisualEffectOverflow const): Adjust the shadow
offsets as necessary.
(WebCore::RenderBox::flippedClientBoxRect const): Drive-by cleanup.
Canonical link: https://commits.webkit.org/295977@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
