Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c710b3e74570dd69487ac9b9a72ebc1ffb0f80f3
https://github.com/WebKit/WebKit/commit/c710b3e74570dd69487ac9b9a72ebc1ffb0f80f3
Author: Darin Adler <[email protected]>
Date: 2025-06-09 (Mon, 09 Jun 2025)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/animations/resources/animation-test-helpers.js
M LayoutTests/fast/css/CSSStyleDeclaration-parameters-expected.txt
M LayoutTests/fast/css/CSSStyleDeclaration-parameters.html
M LayoutTests/fast/css/font-systemFontID-parsing-expected.txt
M LayoutTests/fast/css/font-systemFontID-parsing.html
M LayoutTests/fast/css/getComputedStyle/computed-style-font-expected.txt
M LayoutTests/fast/css/getComputedStyle/computed-style-font.html
M
LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-position-expected.txt
M
LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-position.html
M
LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt
M
LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand.html
M
LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt
M
LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-size.html
M
LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt
M
LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html
M
LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt
M
LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html
M LayoutTests/fast/css3-text/font-synthesis-parse-expected.txt
M LayoutTests/fast/css3-text/font-synthesis-parse.html
R
LayoutTests/platform/glib/transitions/svg-text-shadow-transition-expected.txt
R
LayoutTests/platform/gtk/transitions/svg-text-shadow-transition-expected.png
R
LayoutTests/platform/ios/transitions/svg-text-shadow-transition-expected.txt
R
LayoutTests/platform/mac/transitions/svg-text-shadow-transition-expected.png
R
LayoutTests/platform/mac/transitions/svg-text-shadow-transition-expected.txt
R
LayoutTests/platform/win/transitions/svg-text-shadow-transition-expected.txt
M LayoutTests/transitions/frames-timing-function-expected.txt
M LayoutTests/transitions/lengthsize-transition-to-from-auto-expected.txt
M LayoutTests/transitions/lengthsize-transition-to-from-auto.html
M LayoutTests/transitions/resources/transition-test-helpers.js
A LayoutTests/transitions/svg-text-shadow-transition-expected.txt
M LayoutTests/transitions/svg-text-shadow-transition.html
M LayoutTests/transitions/transition-to-from-auto.html
M LayoutTests/transitions/transition-to-from-undefined.html
Log Message:
-----------
Eliminate use of getPropertyCSSValue from tests, part 2
https://bugs.webkit.org/show_bug.cgi?id=293590
rdar://152048914
Reviewed by Anne van Kesteren and Sam Weinig.
Some of this is removing possibly-useful test coverage; we should be cautious
about that.
See comments in https://github.com/WebKit/WebKit/pull/45904
* LayoutTests/TestExpectations: Expect
transitions/svg-text-shadow-transition.html to pass.
There is some risk that it will now be flaky, and we'll have to add another
flakiness expectation like the ones from webkit.org/b/137883.
* LayoutTests/animations/resources/animation-test-helpers.js:
(getPropertyValue): Rewrote this to have fewer special cases and not use
getPropertyCSSValue at all.
* LayoutTests/fast/css/CSSStyleDeclaration-parameters-expected.txt: Updated.
* LayoutTests/fast/css/CSSStyleDeclaration-parameters.html: Test
getPropertyValue
instead of getPropertyCSSValue.
* LayoutTests/fast/css/font-systemFontID-parsing-expected.txt: Updated.
* LayoutTests/fast/css/font-systemFontID-parsing.html: Test getPropertyValue
instead
of getPropertyCSSValue. Use js-test.js.
* LayoutTests/fast/css/getComputedStyle/computed-style-font-expected.txt:
Updated.
* LayoutTests/fast/css/getComputedStyle/computed-style-font.html: Removed the
tests of
getPropertyCSSValue. Simplified the tests that were left behind.
*
LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-position-expected.txt:
Updated.
*
LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-position.html:
Removed the test of getPropertyCSSValue.
*
LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt:
Updated.
*
LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand.html:
Removed the tests of getPropertyCSSValue. Simplified the tests that were left
behind.
*
LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt:
Updated.
* LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-size.html:
Removed the tests of getPropertyCSSValue. Simplified the tests that were left
behind.
*
LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt:
Updated.
*
LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html:
Removed the tests of getPropertyCSSValue. Simplified the tests that were left
behind.
*
LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt:
Updated.
*
LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html:
Test with getPropertyValue instead of getPropertyCSSValue.
* LayoutTests/fast/css3-text/font-synthesis-parse-expected.txt: Updated.
* LayoutTests/fast/css3-text/font-synthesis-parse.html: Test with
getPropertyValue
instead of getPropertyCSSValue.
*
LayoutTests/platform/glib/transitions/svg-text-shadow-transition-expected.txt:
Removed.
* LayoutTests/platform/gtk/transitions/svg-text-shadow-transition-expected.png:
Removed.
* LayoutTests/platform/ios/transitions/svg-text-shadow-transition-expected.txt:
Removed.
* LayoutTests/platform/mac/transitions/svg-text-shadow-transition-expected.png:
Removed.
* LayoutTests/platform/mac/transitions/svg-text-shadow-transition-expected.txt:
Removed.
* LayoutTests/platform/win/transitions/svg-text-shadow-transition-expected.txt:
Removed.
* LayoutTests/transitions/frames-timing-function-expected.txt: Updated expected
failure messages since the test helper now helpfully cites the single value
instead
of the whole matrix.
* LayoutTests/transitions/lengthsize-transition-to-from-auto-expected.txt:
Updated.
* LayoutTests/transitions/lengthsize-transition-to-from-auto.html: Added an
expected
value of "auto" since the test helper no longer ignores its presence.
* LayoutTests/transitions/resources/transition-test-helpers.js: Rewrote the
checking
code to use the expected value types to decide what kind of comparision to do
and use
the string computed style value rather than using the result of
getPropertyCSSValue.
* LayoutTests/transitions/svg-text-shadow-transition-expected.txt: Added.
This is now a text based text rather than a pixel test.
* LayoutTests/transitions/svg-text-shadow-transition.html: Change expectations
to
match the serialization of text-shadow, including the color.
* LayoutTests/transitions/transition-to-from-auto.html: Expect the number 50
rather
than the string "50" now that the test helper uses the expected type to figure
out
how to check values. Alternatively could have expected the string "50px", but
this
preserves the old behavior and the tolerance.
* LayoutTests/transitions/transition-to-from-undefined.html: Expect the numbers
100
and 50 rather than the strings "100" and "50" now that the test helper uses the
expected
type to figure out how to check values. Alternatively could have expected the
strings
"100px" and "50px", but this preserves the old behavior and the tolerance.
Canonical link: https://commits.webkit.org/295994@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
