Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9c6fd9ba28a57dc52e30138802cf87fd282f3ce
      
https://github.com/WebKit/WebKit/commit/c9c6fd9ba28a57dc52e30138802cf87fd282f3ce
  Author: Nikolaos Mouchtaris <[email protected]>
  Date:   2025-06-09 (Mon, 09 Jun 2025)

  Changed paths:
    A LayoutTests/http/tests/site-isolation/fullscreen-escape-key-expected.txt
    A LayoutTests/http/tests/site-isolation/fullscreen-escape-key.html
    A LayoutTests/http/tests/site-isolation/resources/fullscreen-escape-key.html
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/dom/DocumentFullscreen.cpp

  Log Message:
  -----------
  [Site Isolation] Escape doesn't exit fullscreen with site isolated fullscreen 
content
https://bugs.webkit.org/show_bug.cgi?id=293989
rdar://150307508

Reviewed by Tim Nguyen.

Hitting escape routes the key event to the correct process and eventually calls 
down into
DocumentFullscreen::fullyExitFullscreen, which currently doesn't work for 
subframe processes,
as mainFrameDocument() will return null. Instead use the root frame's document 
for this case.

* LayoutTests/http/tests/site-isolation/fullscreen-escape-key-expected.txt: 
Added.
* LayoutTests/http/tests/site-isolation/fullscreen-escape-key.html: Added.
* LayoutTests/http/tests/site-isolation/resources/fullscreen-escape-key.html: 
Added.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::fullyExitFullscreen):

Canonical link: https://commits.webkit.org/296004@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to