Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6c4ef1d757f2a0e7f47d50684ddcbe818b252fa6
https://github.com/WebKit/WebKit/commit/6c4ef1d757f2a0e7f47d50684ddcbe818b252fa6
Author: Wenson Hsieh <[email protected]>
Date: 2025-06-10 (Tue, 10 Jun 2025)
Changed paths:
A
LayoutTests/fast/page-color-sampling/color-sampling-ignores-large-sticky-container-expected.txt
A
LayoutTests/fast/page-color-sampling/color-sampling-ignores-large-sticky-container.html
R
LayoutTests/fast/page-color-sampling/color-sampling-ignores-modal-popup-expected.txt
R
LayoutTests/fast/page-color-sampling/color-sampling-ignores-modal-popup.html
A
LayoutTests/fast/page-color-sampling/color-sampling-modal-popup-expected.txt
A LayoutTests/fast/page-color-sampling/color-sampling-modal-popup.html
M Source/WebCore/page/LocalFrameView.cpp
Log Message:
-----------
[Safari] [Liquid Glass] Turn Off The Lights extension has no color fill
behind navigation bar
https://bugs.webkit.org/show_bug.cgi?id=294262
rdar://152865474
Reviewed by Abrar Rahman Protyasha.
Dial back some of the mitigations implemented in 295724@main that avoid
detecting large viewport-
constrained containers for color extension. In the case of a dimming layer that
covers the entire
viewport, failing to extend edge colors causes Safari UI to look broken, as
there's either a gap or
different color around the dimming layer.
Keep both cases working by not rejecting large viewport-constrained elements in
the case where they
look like they're intended to dim the webpage.
*
LayoutTests/fast/page-color-sampling/color-sampling-ignores-large-sticky-container-expected.txt:
Added.
*
LayoutTests/fast/page-color-sampling/color-sampling-ignores-large-sticky-container.html:
Added.
Add a new layout test to verify that a large, scrollable sticky container that
contains content
doesn't trigger color extension.
*
LayoutTests/fast/page-color-sampling/color-sampling-ignores-modal-popup-expected.txt:
Removed.
* LayoutTests/fast/page-color-sampling/color-sampling-modal-popup-expected.txt:
Added.
* LayoutTests/fast/page-color-sampling/color-sampling-modal-popup.html: Renamed
from
LayoutTests/fast/page-color-sampling/color-sampling-ignores-modal-popup.html.
Rename this test from `color-sampling-ignores-modal-popup.html` to
`color-sampling-modal-popup.html`
and adjust it so that it expects colors to change as the modal container is
presented.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::fixedContainerEdges const):
See above.
Canonical link: https://commits.webkit.org/296056@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes