Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8ea398a5e6b3706609203186eb96c55a5480e806
https://github.com/WebKit/WebKit/commit/8ea398a5e6b3706609203186eb96c55a5480e806
Author: Chris Dumez <[email protected]>
Date: 2025-06-10 (Tue, 10 Jun 2025)
Changed paths:
M Source/WebKit/WebProcess/WebCoreSupport/WebGeolocationClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebGeolocationClient.h
Log Message:
-----------
Crash in WebGeolocationClient::geolocationDestroyed
https://bugs.webkit.org/show_bug.cgi?id=289999
rdar://147875308
Reviewed by Per Arne Vollan.
Make m_page a WeakPtr since it can become null. WebGeolocationClient is owned by
WebCore::Page, not WebKit::WebPage and m_page is a WebPage. The Page can outlive
the WebPage since it is refcounted.
* Source/WebKit/WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
(WebKit::WebGeolocationClient::WebGeolocationClient):
(WebKit::WebGeolocationClient::geolocationDestroyed):
(WebKit::WebGeolocationClient::startUpdating):
(WebKit::WebGeolocationClient::stopUpdating):
(WebKit::WebGeolocationClient::setEnableHighAccuracy):
(WebKit::WebGeolocationClient::requestPermission):
(WebKit::WebGeolocationClient::revokeAuthorizationToken):
(WebKit::WebGeolocationClient::cancelPermissionRequest):
(WebKit::WebGeolocationClient::~WebGeolocationClient): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebGeolocationClient.h:
Canonical link: https://commits.webkit.org/296054@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
