Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 312266846edf6e24d712c47bc872224f3d1bf785
https://github.com/WebKit/WebKit/commit/312266846edf6e24d712c47bc872224f3d1bf785
Author: Devin Rousso <[email protected]>
Date: 2025-06-10 (Tue, 10 Jun 2025)
Changed paths:
M LayoutTests/inspector/console/message-stack-trace-expected.txt
M LayoutTests/inspector/console/message-stack-trace.html
A LayoutTests/inspector/console/resources/import-throw.js
M LayoutTests/inspector/console/resources/log-console-stack-trace.js
A LayoutTests/inspector/console/resources/throw.js
M LayoutTests/inspector/debugger/resources/async-stack-trace-test.js
M LayoutTests/inspector/debugger/resources/log-active-stack-trace.js
M
LayoutTests/inspector/debugger/tail-deleted-frames/resources/stack-trace-utilities.js
M Source/JavaScriptCore/inspector/AsyncStackTrace.cpp
M Source/JavaScriptCore/inspector/AsyncStackTrace.h
M Source/JavaScriptCore/inspector/ScriptCallStack.cpp
Log Message:
-----------
Web Inspector: REGRESSION(?): Sources Tab: async stack traces can sometimes
be empty
https://bugs.webkit.org/show_bug.cgi?id=294065
Reviewed by BJ Burg.
There's really no benefit in showing the developer that there was an (async)
parent stack trace if nothing is in it (not counting the boundary).
* Source/JavaScriptCore/inspector/AsyncStackTrace.h:
* Source/JavaScriptCore/inspector/AsyncStackTrace.cpp:
(Inspector::AsyncStackTrace::buildInspectorObject const):
* Source/JavaScriptCore/inspector/ScriptCallStack.cpp:
(Inspector::ScriptCallStack::buildInspectorObject const):
Sanitize the generated `Inspector::Protocol::Console::StackTrace` object by
skipping any that are empty (which might mean that there end up being no
(async) parent stack traces to show).
* LayoutTests/inspector/console/message-stack-trace.html:
* LayoutTests/inspector/console/message-stack-trace-expected.txt:
* LayoutTests/inspector/console/resources/import-throw.js: Added.
* LayoutTests/inspector/console/resources/throw.js: Added.
Add a test for one reproducable scenario using dynamic `import(...)` as that
seems to involve bunch of JS that's marked `ImplementationVisibility::Private`
which results in (async) stack traces that only contain the `enqueueJob`
boundary frame (which as stated above is pretty useless).
* LayoutTests/inspector/console/resources/log-console-stack-trace.js:
(logConsoleMessageStackTrace):
* LayoutTests/inspector/debugger/resources/async-stack-trace-test.js:
(logAsyncStackTrace):
* LayoutTests/inspector/debugger/resources/log-active-stack-trace.js:
(logStackTrace):
*
LayoutTests/inspector/debugger/tail-deleted-frames/resources/stack-trace-utilities.js:
(logAsyncStackTrace):
Add more logging just in case this ever regresses in other situations.
Canonical link: https://commits.webkit.org/296069@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
