Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ce9a4fafb44ecf70b9c84a30a544748cd90eb1c5
https://github.com/WebKit/WebKit/commit/ce9a4fafb44ecf70b9c84a30a544748cd90eb1c5
Author: Richard Robinson <[email protected]>
Date: 2025-06-14 (Sat, 14 Jun 2025)
Changed paths:
M Tools/TestWebKitAPI/TestPDFDocument.swift
M Tools/TestWebKitAPI/Tests/WebKitCocoa/DrawingToPDF.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm
M Tools/TestWebKitAPI/Tests/ios/ApplicationStateTracking.mm
M Tools/TestWebKitAPI/ios/TestPDFHostViewController.h
M Tools/TestWebKitAPI/ios/TestPDFHostViewController.mm
Log Message:
-----------
Fix some PDF tests after 296104@main
https://bugs.webkit.org/show_bug.cgi?id=294482
rdar://153344673
Reviewed by Abrar Rahman Protyasha.
296104@main accidentally broke some PDF tests, but it also conveniently also
accidentally
disabled those same tests because it didn't replace the PDFKIT_FOR_TESTING flag
everywhere.
Fix that, and then fix some minor issues in the test implementation;
specifically:
- The pixel buffer was too small
- Colors were being compared incorrectly due to color space differences; fix
this by using the Util::compareColors
function instead.
* Tools/TestWebKitAPI/TestPDFDocument.swift:
(TestPDFPage.color(at:)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/DrawingToPDF.mm:
(TestWebKitAPI::TEST(DrawingToPDF, GradientIntoPDF)):
(TestWebKitAPI::TEST(DrawingToPDF, BackgroundClipText)):
(TestWebKitAPI::TEST(DrawingToPDF, SiteIsolationFormControl)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
(TestWebKitAPI::TEST(PDFSnapshot, FullContent)):
(TestWebKitAPI::TEST(PDFSnapshot, Subregions)):
(TestWebKitAPI::TEST(PDFSnapshot, Over200Inches)):
(TestWebKitAPI::TEST(PDFSnapshot, Links)):
(TestWebKitAPI::TEST(PDFSnapshot, AllowTransparentBackground)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm:
* Tools/TestWebKitAPI/Tests/ios/ApplicationStateTracking.mm:
* Tools/TestWebKitAPI/ios/TestPDFHostViewController.h:
* Tools/TestWebKitAPI/ios/TestPDFHostViewController.mm:
Canonical link: https://commits.webkit.org/296229@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
