Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c3c083fd58975d9243b017b9384fcff76be88ec6
https://github.com/WebKit/WebKit/commit/c3c083fd58975d9243b017b9384fcff76be88ec6
Author: Ahmad Saleem <[email protected]>
Date: 2025-06-14 (Sat, 14 Jun 2025)
Changed paths:
A LayoutTests/fast/frames/abspos-display-none-frameset-crash-expected.txt
A LayoutTests/fast/frames/abspos-display-none-frameset-crash.html
A LayoutTests/fast/multicol/abspos-display-none-frameset-crash-expected.txt
A LayoutTests/fast/multicol/abspos-display-none-frameset-crash.html
M Source/WebCore/style/StyleAdjuster.cpp
Log Message:
-----------
FRAME and FRAMESET should always be in-flow (and non-floating)
https://bugs.webkit.org/show_bug.cgi?id=248088
rdar://102670652
Reviewed by Alan Baradlay.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
Merge:
https://chromium.googlesource.com/chromium/src.git/+/f47b628e85e5195efc1f152c2bc7a19d20c85fa0
Frames and framesets ignore display:none, and will render no matter
what. The style adjuster would check for display != none, before
attempting to adjust, and would therefore just do nothing and accept
whatever.
We only used to override display and position (force to "block" and
"static", respectively). Additionally force "float" to "none", as
framesets are really unsuitable containing blocks. It aligns with
other browser engines as well.
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
* LayoutTests/fast/multicol/abspos-display-none-frameset-crash.html:
* LayoutTests/fast/multicol/abspos-display-none-frameset-crash-expected.txt:
* LayoutTests/fast/frames/abspos-display-none-frameset-crash.html:
* LayoutTests/fast/frames/abspos-display-none-frameset-crash-expected.txt:
Canonical link: https://commits.webkit.org/296236@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
