Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5574e1a1ec10f41c9d9782106e9528a2aee6eca0
https://github.com/WebKit/WebKit/commit/5574e1a1ec10f41c9d9782106e9528a2aee6eca0
Author: Sam Weinig <[email protected]>
Date: 2025-06-16 (Mon, 16 Jun 2025)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom.html
M Source/WebCore/Headers.cmake
M
Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/animation/BlendingKeyframes.cpp
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/css/CSSCustomPropertyValue.cpp
M Source/WebCore/css/CSSCustomPropertyValue.h
M Source/WebCore/css/CSSProperty.h
M Source/WebCore/css/CSSRegisteredCustomProperty.h
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/CSSVariableReferenceValue.cpp
A Source/WebCore/css/CSSWideKeyword.h
M Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp
M Source/WebCore/css/parser/CSSParserIdioms.h
M Source/WebCore/css/parser/CSSPropertyParser.cpp
M Source/WebCore/css/parser/CSSPropertyParser.h
M Source/WebCore/css/parser/CSSVariableParser.cpp
M Source/WebCore/css/parser/CSSVariableParser.h
M Source/WebCore/css/query/ContainerQueryFeatures.cpp
M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
M Source/WebCore/css/typedom/CSSStyleValueFactory.h
M Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp
M Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp
M Source/WebCore/css/typedom/StylePropertyMapReadOnly.cpp
M Source/WebCore/css/values/CSSValueAggregates.h
M Source/WebCore/css/values/CSSValueTypes.h
A Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+Logging.h
M Source/WebCore/css/values/primitives/CSSSymbol.cpp
M Source/WebCore/css/values/primitives/CSSSymbol.h
M Source/WebCore/dom/ConstantPropertyMap.cpp
M Source/WebCore/dom/ConstantPropertyMap.h
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/StyleCustomPropertyData.cpp
M Source/WebCore/rendering/style/StyleCustomPropertyData.h
M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
M Source/WebCore/rendering/style/StyleRareInheritedData.h
M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
M Source/WebCore/rendering/style/StyleRareNonInheritedData.h
R Source/WebCore/style/CustomPropertyRegistry.cpp
R Source/WebCore/style/CustomPropertyRegistry.h
M Source/WebCore/style/MatchedDeclarationsCache.cpp
M Source/WebCore/style/MatchedDeclarationsCache.h
M Source/WebCore/style/PropertyCascade.cpp
M Source/WebCore/style/RuleSetBuilder.cpp
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/style/StyleBuilder.h
A Source/WebCore/style/StyleCustomProperty.cpp
A Source/WebCore/style/StyleCustomProperty.h
A Source/WebCore/style/StyleCustomPropertyRegistry.cpp
A Source/WebCore/style/StyleCustomPropertyRegistry.h
M Source/WebCore/style/StyleExtractor.cpp
M Source/WebCore/style/StyleExtractor.h
M Source/WebCore/style/StyleExtractorConverter.h
M Source/WebCore/style/StyleExtractorCustom.h
M Source/WebCore/style/StyleInterpolation.cpp
M Source/WebCore/style/StyleScope.cpp
M Source/WebCore/style/Styleable.cpp
M Source/WebCore/style/values/StyleValueTypes.h
M Source/WebCore/style/values/primitives/StylePosition.cpp
Log Message:
-----------
[Style] Split CSS custom property representation into CSS and Style parts
https://bugs.webkit.org/show_bug.cgi?id=294485
Reviewed by Darin Adler.
Split the computed custom property representation out of CSSCustomPropertyValue
and into a new type, Style::CustomProperty.
Previously, the same type, CSSCustomPropertyValue, was used for both the
specified (CSS)
value and computed (Style) values, but much of the state space was only valid in
one or the other. Now we are explicit and no longer have invalid states.
With the new non-CSSValue representation, an additional function was needed to
convert to CSSValue for CSSOM (both legacy and typed). Doing this using the
standard extractor based mechanisms led to some test progressions.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom.html:
(updated to match spec requiring computed URL to be absolute)
* Source/WebCore/Headers.cmake
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/BlendingKeyframes.cpp:
* Source/WebCore/animation/KeyframeEffect.cpp:
* Source/WebCore/css/CSSCustomPropertyValue.cpp:
* Source/WebCore/css/CSSCustomPropertyValue.h:
* Source/WebCore/css/CSSProperty.h:
* Source/WebCore/css/CSSRegisteredCustomProperty.h:
* Source/WebCore/css/CSSValue.h:
* Source/WebCore/css/CSSVariableReferenceValue.cpp:
* Source/WebCore/css/CSSWideKeyword.h: Added.
* Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp:
* Source/WebCore/css/parser/CSSParserIdioms.h:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
* Source/WebCore/css/parser/CSSPropertyParser.h:
* Source/WebCore/css/parser/CSSVariableParser.cpp:
* Source/WebCore/css/parser/CSSVariableParser.h:
* Source/WebCore/css/query/ContainerQueryFeatures.cpp:
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
* Source/WebCore/css/typedom/CSSStyleValueFactory.h:
* Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp:
* Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp:
* Source/WebCore/css/typedom/StylePropertyMapReadOnly.cpp:
* Source/WebCore/css/values/CSSValueAggregates.h:
* Source/WebCore/css/values/CSSValueTypes.h:
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes+Logging.h:
Added.
* Source/WebCore/css/values/primitives/CSSSymbol.cpp:
* Source/WebCore/css/values/primitives/CSSSymbol.h:
* Source/WebCore/dom/ConstantPropertyMap.cpp:
* Source/WebCore/dom/ConstantPropertyMap.h:
* Source/WebCore/rendering/style/RenderStyle.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
* Source/WebCore/rendering/style/StyleCustomPropertyData.cpp:
* Source/WebCore/rendering/style/StyleCustomPropertyData.h:
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
* Source/WebCore/style/MatchedDeclarationsCache.cpp:
* Source/WebCore/style/MatchedDeclarationsCache.h:
* Source/WebCore/style/PropertyCascade.cpp:
* Source/WebCore/style/RuleSetBuilder.cpp:
* Source/WebCore/style/StyleBuilder.cpp:
* Source/WebCore/style/StyleBuilder.h:
* Source/WebCore/style/StyleCustomProperty.cpp: Added.
* Source/WebCore/style/StyleCustomProperty.h: Added.
* Source/WebCore/style/StyleCustomPropertyRegistry.cpp: Renamed from
Source/WebCore/style/CustomPropertyRegistry.cpp.
* Source/WebCore/style/StyleCustomPropertyRegistry.h: Renamed from
Source/WebCore/style/CustomPropertyRegistry.h.
* Source/WebCore/style/StyleExtractor.cpp:
* Source/WebCore/style/StyleExtractor.h:
* Source/WebCore/style/StyleExtractorConverter.h:
* Source/WebCore/style/StyleExtractorCustom.h:
* Source/WebCore/style/StyleInterpolation.cpp:
* Source/WebCore/style/StyleScope.cpp:
* Source/WebCore/style/Styleable.cpp:
* Source/WebCore/style/values/StyleValueTypes.h:
* Source/WebCore/style/values/primitives/StylePosition.cpp:
* Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Logging.h:
Canonical link: https://commits.webkit.org/296287@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
