Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d323b2fc4cd2686c828bd8976fae6ec2d2b6311c
      
https://github.com/WebKit/WebKit/commit/d323b2fc4cd2686c828bd8976fae6ec2d2b6311c
  Author: Alex Christensen <[email protected]>
  Date:   2025-06-16 (Mon, 16 Jun 2025)

  Changed paths:
    M LayoutTests/http/tests/site-isolation/resources/update-background.html
    M Source/WebCore/dom/Document.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp

  Log Message:
  -----------
  Call owner document's checkCompleted in WebRemoteFrameClient::frameDetached
https://bugs.webkit.org/show_bug.cgi?id=294569

Reviewed by Charlie Wolfe.

If we remove a RemoteFrame from the tree before or during the load event, then 
by the time
WebPage::didFinishLoadInAnotherProcess is called there is no more frame to be 
found so we
do nothing and the load event of the parent is never called.  To fix this, when 
removing a
LocalFrame, call the parent document's checkCompleted function if it is in the 
same process.
Document::checkCompleted is intended to be able to be called multiple times, 
and if it is
not completed loading yet it does nothing.

* LayoutTests/http/tests/site-isolation/resources/update-background.html:
* Source/WebCore/dom/Document.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:
(WebKit::WebRemoteFrameClient::frameDetached):

Canonical link: https://commits.webkit.org/296294@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to