Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 71cbb1ee223bcca3a73efccd837600ae58b913c6
https://github.com/WebKit/WebKit/commit/71cbb1ee223bcca3a73efccd837600ae58b913c6
Author: Jer Noble <[email protected]>
Date: 2025-06-17 (Tue, 17 Jun 2025)
Changed paths:
A
LayoutTests/fullscreen/fullscreen-zero-height-element-with-non-zero-children-expected.txt
A
LayoutTests/fullscreen/fullscreen-zero-height-element-with-non-zero-children.html
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
Log Message:
-----------
[macOS] Fullscreen animation looks incorrect on ign.com
rdar://152181188
https://bugs.webkit.org/show_bug.cgi?id=294209
Reviewed by Eric Carlson.
IGN.com requests fullscreen on an element whose height is explicitly zero, and
with an absolute
positioned child. screenRectOfContents() would return a zero-height rect, and
this would cause
the fullscreen animation to start and end at the wrong visual position.
Update screenRectOfContents() to use paintingRootRect() rather than
screenRect().
*
LayoutTests/fullscreen/fullscreen-zero-height-element-with-non-zero-children-expected.txt:
Added.
*
LayoutTests/fullscreen/fullscreen-zero-height-element-with-non-zero-children.html:
Added.
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::screenRectOfContents):
(WebKit::WebFullScreenManager::enterFullScreenForElement):
(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):
Canonical link: https://commits.webkit.org/296331@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
