Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d068bfd5c61df539931b97b2193dc8adedf2b5e9
https://github.com/WebKit/WebKit/commit/d068bfd5c61df539931b97b2193dc8adedf2b5e9
Author: Wenson Hsieh <[email protected]>
Date: 2025-06-17 (Tue, 17 Jun 2025)
Changed paths:
M
LayoutTests/fast/page-color-sampling/color-sampling-while-rubber-banding.html
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
Log Message:
-----------
[Liquid Glass] solidcore.com: top sampled color changes when scrolling
against the top of the page
https://bugs.webkit.org/show_bug.cgi?id=294621
rdar://153151667
Reviewed by Abrar Rahman Protyasha.
Adjust the heuristics for determining sampled colors along viewport edges, to
maintain stability in
a couple more scenarios:
1. When rubber-banding against viewport edges, keep the sampled top color
stable by falling back to
the last color (as long as the hit-tested element is still in the render
tree).
2. In the case where the fixed viewport edge loses its predominant color but
the previously
sampled element is still in the render tree, fall back to the last sampled
color.
* LayoutTests/fast/page-color-sampling/color-sampling-while-rubber-banding.html:
Augment an existing test to cover this case, by changing the color of the
header while rubber-
banding.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::fixedContainerEdges const):
Remove unnecessary code to expand the hit-test region while rubber-banding, now
that we just fall
back to the last color.
* Source/WebCore/page/Page.cpp:
(WebCore::Page::updateFixedContainerEdges):
(WebCore::Page::lastTopFixedContainerColor const): Deleted.
Remove this helper method, which is no longer needed.
* Source/WebCore/page/Page.h:
Canonical link: https://commits.webkit.org/296334@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
