Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 71871b592a2fe399d0e1c041de1225a504ff66a6
https://github.com/WebKit/WebKit/commit/71871b592a2fe399d0e1c041de1225a504ff66a6
Author: Ben Schwartz <[email protected]>
Date: 2025-06-17 (Tue, 17 Jun 2025)
Changed paths:
M Tools/Scripts/webkitpy/common/version_name_map.py
M Tools/Scripts/webkitpy/port/darwin.py
M Tools/Scripts/webkitpy/port/ios.py
M Tools/Scripts/webkitpy/port/ios_device_unittest.py
M Tools/Scripts/webkitpy/port/ios_simulator_unittest.py
M Tools/Scripts/webkitpy/port/ios_testcase.py
M Tools/Scripts/webkitpy/port/mac.py
M Tools/Scripts/webkitpy/port/visionos.py
M Tools/Scripts/webkitpy/port/visionos_testcase.py
M Tools/Scripts/webkitpy/port/watch.py
M Tools/Scripts/webkitpy/port/watch_simulator_unittest.py
M Tools/Scripts/webkitpy/port/watch_testcase.py
Log Message:
-----------
[webkitpy] Move default CURRENT_VERSION variable definition to DarwinPort.
https://bugs.webkit.org/show_bug.cgi?id=294287
rdar://153002661
Reviewed by Jonathan Bedard.
Now that all Apple port versions are 26, we can synthesize all of the different
CURRENT_VERSION definitions by port into one definition in DarwinPort. If we
have different versioning for whatever reason (maybe differences in minor
version?), we can always override that in the subclasses.
This change also changes associated unit tests to use the current version
rather than manually defining it every time, requiring fewer changes each year.
* Tools/Scripts/webkitpy/common/version_name_map.py:
(VersionNameMap)
-> (__init__): Pull CURRENT_VERSION from port objects for iOS, tvOS,
watchOS, and visionOS.
(Not for macOS, as this requires a manual change to
define new version names yearly anyway.)
* Tools/Scripts/webkitpy/port/darwin.py:
(DarwinPort): Set default for CURRENT_VERSION to `Version(26)`.
* Tools/Scripts/webkitpy/port/ios.py:
(IOSPort): Remove CURRENT_VERSION definition that overrides DarwinPort.
* Tools/Scripts/webkitpy/port/mac.py:
(MacPort): Ditto.
* Tools/Scripts/webkitpy/port/visionos.py:
(VisionOSPort): Ditto.
* Tools/Scripts/webkitpy/port/watch.py:
(WatchPort): Ditto.
* Tools/Scripts/webkitpy/port/ios_device_unittest.py: Change unit tests to use
CURRENT_VERSION from associated ports.
* Tools/Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
* Tools/Scripts/webkitpy/port/ios_testcase.py: Ditto.
* Tools/Scripts/webkitpy/port/visionos_testcase.py: Ditto.
* Tools/Scripts/webkitpy/port/watch_simulator_unittest.py: Ditto.
* Tools/Scripts/webkitpy/port/watch_testcase.py: Ditto.
Canonical link: https://commits.webkit.org/296346@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
