Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d53eab19d91a5804a9f9a5626352ee711ded7a6f
      
https://github.com/WebKit/WebKit/commit/d53eab19d91a5804a9f9a5626352ee711ded7a6f
  Author: Sammy Gill <[email protected]>
  Date:   2025-06-17 (Tue, 17 Jun 2025)

  Changed paths:
    M LayoutTests/TestExpectations
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-column-horz-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-column-horz-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-column-horz-ref.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-column-horz.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-column-vert-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-column-vert-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-column-vert-ref.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-column-vert.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-row-horz-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-row-horz-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-row-horz-ref.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-row-horz.html
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-row-vert-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-row-vert-expected.txt
    R 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-row-vert-ref.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/align-items-baseline-row-vert.html

  Log Message:
  -----------
  Modify css-flexbox/align-items-baseline-* tests to use checkLayout
https://bugs.webkit.org/show_bug.cgi?id=294630
rdar://153672240

Reviewed by Alan Baradlay.

These tests currently use grid baseline alignment for the expectation
files, which is not great since that has its own set of bugs. In fact, we
are already passing one of the tests marked as failing since we fail to
render the expectation properly. Many other tests for baseline alignment
in Flexbox already use checkLayout (see css-flexbox/alignment/ tests).

To allow the content to render the same across engines and reduce font
differences, I also modified the tests to use the Ahem font and also
specified an explicit line-height where needed as per: To reduce the 
differences from

https://web-platform-tests.org/writing-tests/ahem.html
Canonical link: https://commits.webkit.org/296351@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to