Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4778085003950fa1be48f2c70bb52d9c85ed3598
https://github.com/WebKit/WebKit/commit/4778085003950fa1be48f2c70bb52d9c85ed3598
Author: Wenson Hsieh <[email protected]>
Date: 2025-06-18 (Wed, 18 Jun 2025)
Changed paths:
A
LayoutTests/fast/page-color-sampling/color-sampling-stability-for-same-element-expected.txt
A
LayoutTests/fast/page-color-sampling/color-sampling-stability-for-same-element.html
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
Log Message:
-----------
[Liquid Glass] [macOS] quantamagazine.org: tab bar flickers when scrolling
against the top of the page
https://bugs.webkit.org/show_bug.cgi?id=294689
rdar://153120810
Reviewed by Aditya Keerthi.
Further improve sampled color stability for fixed elements around the edges of
the viewport by
falling back to the previously sampled color if the hit-tested element has not
changed. While this
may leave the top sampled color different than the current color of the fixed
element, it avoids
common scenarios where the background of Safari's tab bar changes too
frequently or flickers.
Note that this also has potential performance benefits, since we'll only
snapshot and sample an
element once, until we stop hit-testing to it.
*
LayoutTests/fast/page-color-sampling/color-sampling-stability-for-same-element-expected.txt:
Added.
*
LayoutTests/fast/page-color-sampling/color-sampling-stability-for-same-element.html:
Added.
Add a layout test with a top fixed header loosely based on quantamagazine.org;
verifies that the
sampled color remains stable after scrolling down (showing the solid orange
color), and then
scrolling back up.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::fixedContainerEdges const):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::lastFixedContainer const):
* Source/WebCore/page/Page.h:
Canonical link: https://commits.webkit.org/296401@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
