Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2edcd1e56e940009ee341fe1bdf61e21a1964e86
      
https://github.com/WebKit/WebKit/commit/2edcd1e56e940009ee341fe1bdf61e21a1964e86
  Author: Ioanna M. Dimitriou H <[email protected]>
  Date:   2025-06-19 (Thu, 19 Jun 2025)

  Changed paths:
    M JSTests/wasm/gc/ref-i31-eq.js
    M Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp

  Log Message:
  -----------
  Homogenize handling of i31 methods across tiers on 32-bits
https://bugs.webkit.org/show_bug.cgi?id=294725

Reviewed by Yusuke Suzuki.

Homogenise the processes of i31 ref methods in BBQJIT, to avoid discrepancies 
when performing OSR,
by following the approach used for 64 bit tiers, and in the OMG and LLInt tiers 
for 32 bit.
That is, only sign-extend when creating the i31 ref, and apply the 0x7fffffff 
mask in the unsigned case.

Also re-enable now-passing test gc/ref-i31-eq.js.

Co-authored-by: Angelos Oikonomopoulos <[email protected]>

* JSTests/wasm/gc/ref-i31-eq.js:
* Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::addRefI31):
(JSC::Wasm::BBQJITImpl::BBQJIT::addI31GetS):
(JSC::Wasm::BBQJITImpl::BBQJIT::addI31GetU):

Canonical link: https://commits.webkit.org/296423@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to