Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 76ee762294ac08f751a17daec6a959751405c44a
https://github.com/WebKit/WebKit/commit/76ee762294ac08f751a17daec6a959751405c44a
Author: Wenson Hsieh <[email protected]>
Date: 2025-06-19 (Thu, 19 Jun 2025)
Changed paths:
M
LayoutTests/fast/page-color-sampling/color-sampling-modal-popup-expected.txt
M LayoutTests/fast/page-color-sampling/color-sampling-modal-popup.html
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/PageColorSampler.cpp
Log Message:
-----------
[Liquid Glass] [macOS] x.com: Top sampled color changes to black when login
sheet is presented
https://bugs.webkit.org/show_bug.cgi?id=294739
rdar://153810118
Reviewed by Abrar Rahman Protyasha.
Make some more adjustments to how fixed edge color sampling works with modal
dimming containers that
cover the entire viewport:
1. Currently, sampled colors are mapped to completely opaque colors, which
ensures that content
above partially-transparent headers don't poke through the tab bar.
However, this doesn't work
well in cases where modal dimming views cover the whole viewport, often
with a low-opacity black
color which becomes a jarring solid black color behind the browser chrome.
To mitigate this,
allow transparent sampled colors only in the case where there's a dimming
layer.
2. Additionally avoid changing sampled colors in the case where there's
already a sampled color on
that edge, to prevent the tab bar from flickering if there's already a top
fixed header when a
modal container appears.
* LayoutTests/fast/page-color-sampling/color-sampling-modal-popup-expected.txt:
* LayoutTests/fast/page-color-sampling/color-sampling-modal-popup.html:
Rebaseline an existing test to reflect that modal dimming layers now only cover
up obscured inset
areas that don't already have fixed edge colors.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::fixedContainerEdges const):
See above.
* Source/WebCore/page/PageColorSampler.cpp:
(WebCore::PageColorSampler::predominantColor):
Canonical link: https://commits.webkit.org/296428@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
