Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b98e5e1c6baa53edf0e7437baedab9f06e4dbd58
https://github.com/WebKit/WebKit/commit/b98e5e1c6baa53edf0e7437baedab9f06e4dbd58
Author: Jean-Yves Avenard <[email protected]>
Date: 2025-06-24 (Tue, 24 Jun 2025)
Changed paths:
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp
M
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.h
M
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm
M
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
M Source/WebCore/platform/graphics/cocoa/SourceBufferParser.cpp
M Source/WebCore/platform/graphics/cocoa/SourceBufferParser.h
M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp
M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h
Log Message:
-----------
[MSE] Remove SourceBufferParser::Segment.
https://bugs.webkit.org/show_bug.cgi?id=243370
rdar://97831219
Reviewed by Youenn Fablet.
We remove the SourceBufferParser::Segment class and directly deal with
SharedBuffer.
To better control lifetime of the segment, we immediately move in
SourceBufferParser::appendData
the rvalue Ref<const SharedBuffer>
Follow-up on 288710@main which fixed long standing issue in
WebMParser::SegmentReader::Read where if the data parsed was across two
segments, we could have returned corrupted data (this was a theoretical issue
that couldn't be reproduced from JS).
No functional changes, covered by existing tests.
* Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp:
(WebCore::AudioFileReader::demuxWebMData const):
*
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.h:
*
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:
(WebCore::SourceBufferParserAVFObjC::appendData):
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::dataReceived):
* Source/WebCore/platform/graphics/cocoa/SourceBufferParser.cpp:
(WebCore::SourceBufferParser::Segment::Segment): Deleted.
(WebCore::SourceBufferParser::Segment::size const): Deleted.
(WebCore::SourceBufferParser::Segment::read const): Deleted.
(WebCore::SourceBufferParser::Segment::takeSharedBuffer): Deleted.
(WebCore::SourceBufferParser::Segment::getData const): Deleted.
* Source/WebCore/platform/graphics/cocoa/SourceBufferParser.h:
* Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::WebMParser::parse):
(WebCore::SourceBufferParserWebM::appendData):
(WebCore::segmentReadErrorToWebmStatus): Deleted.
* Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h:
Canonical link: https://commits.webkit.org/296589@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
