Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b3fe8b76f0523718b025d4f80c03663a996506c1
https://github.com/WebKit/WebKit/commit/b3fe8b76f0523718b025d4f80c03663a996506c1
Author: Razvan Caliman <[email protected]>
Date: 2025-06-26 (Thu, 26 Jun 2025)
Changed paths:
M Source/JavaScriptCore/inspector/ConsoleMessage.cpp
M Source/JavaScriptCore/inspector/protocol/Console.json
M Source/JavaScriptCore/runtime/ConsoleClient.cpp
M Source/JavaScriptCore/runtime/ConsoleTypes.h
M Source/WebCore/inspector/agents/page/PageConsoleAgent.cpp
M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp
M Source/WebKit/Shared/JavaScriptCore.serialization.in
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
M Source/WebKitLegacy/mac/WebKit.exp
M Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h
Log Message:
-----------
Web Inspector: Replace MessageSource::AppCache in WebCore
https://bugs.webkit.org/show_bug.cgi?id=294907
rdar://154202768
Reviewed by Devin Rousso.
ApplicationCache (aka AppCache) is a deprecated feature:
https://bugs.webkit.org/show_bug.cgi?id=181764
Support for inspecting AppCache was removed from WebInspector:
https://commits.webkit.org/289820@main
With the feature is still technically available in WebCore,
it can emit some console messages on an AppCache-specific message channel.
WebInspector frontend doesn't explicitly handle them anymore.
This patch replaces the `MessageSource::AppCache` with `MessageSource::Other`
to ensure that any potential messages still get handled.
* Source/JavaScriptCore/inspector/ConsoleMessage.cpp:
(Inspector::messageSourceValue):
* Source/JavaScriptCore/inspector/protocol/Console.json:
* Source/JavaScriptCore/runtime/ConsoleClient.cpp:
(JSC::appendMessagePrefix):
* Source/JavaScriptCore/runtime/ConsoleTypes.h:
* Source/WebCore/inspector/agents/page/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::getLoggingChannels):
* Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::abort):
(WebCore::ApplicationCacheGroup::didFinishLoadingEntry):
(WebCore::ApplicationCacheGroup::didFailLoadingEntry):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::didFailLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
* Source/WebKit/Shared/JavaScriptCore.serialization.in:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(stringForMessageSource):
* Source/WebKitLegacy/mac/WebKit.exp:
* Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h:
Canonical link: https://commits.webkit.org/296659@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
