Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b0c696557568ae8aa82875fcac5fbd496510ab4
      
https://github.com/WebKit/WebKit/commit/6b0c696557568ae8aa82875fcac5fbd496510ab4
  Author: Vassili Bykov <[email protected]>
  Date:   2025-06-27 (Fri, 27 Jun 2025)

  Changed paths:
    M Source/JavaScriptCore/jsc.cpp

  Log Message:
  -----------
  functionGenerateHeapSnapshot should expect an OOM exception in JSONParse
rdar://150692273
https://bugs.webkit.org/show_bug.cgi?id=294991

Reviewed by Keith Miller.

The crash reported in the radar is an assertion failure that may happen in
`functionGenerateHeapSnapshot` when it calls `JSONParse` to parse a json 
string. The call
is followed by an assertion that no exception was thrown. However, in low memory
conditions parsing may legitimately throw an OutOfMemory exception. This 
happens in ASAN
builds when they run the test case reported in the radar. In non-ASAN builds 
OOM is not
thrown when running the same test case.

The patch changes the shapshot function to expect and propagate exceptions 
thrown in the
parse call.

* Source/JavaScriptCore/jsc.cpp:
(JSC_DEFINE_HOST_FUNCTION):

Canonical link: https://commits.webkit.org/296739@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to