Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ca89498e8f6576d629c2b23c62970b1c9b2eb6f1
      
https://github.com/WebKit/WebKit/commit/ca89498e8f6576d629c2b23c62970b1c9b2eb6f1
  Author: Jer Noble <jer.no...@apple.com>
  Date:   2025-06-27 (Fri, 27 Jun 2025)

  Changed paths:
    M Source/WebCore/bindings/js/JSElementCustom.cpp
    M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
    M Source/WebCore/bindings/scripts/IDLAttributes.json
    M Source/WebCore/dom/DocumentFullscreen.cpp
    M Source/WebCore/dom/Element+Fullscreen.idl
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebCore/page/QuirksData.h

  Log Message:
  -----------
  [iPhone] nba.com: Fullscreen broken when requesting Desktop Website
rdar://133321190
https://bugs.webkit.org/show_bug.cgi?id=294992

Reviewed by Eric Carlson.

Adds a quirk that, because the Destop version of nba.com uses
webkitRequestFullscreen() unconditionally, finds the biggest video inside the
requesting element and takes that video into fullscreen instead.

* Source/WebCore/bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::shouldEnableWebkitRequestFullScreen):
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateRuntimeEnableConditionalString):
* Source/WebCore/bindings/scripts/IDLAttributes.json:
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::requestFullscreen):
* Source/WebCore/dom/Element+Fullscreen.idl:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldEnterNativeFullscreenWhenCallingElementRequestFullscreenQuirk
 const):
(WebCore::handleNBAQuirks):
(WebCore::Quirks::determineRelevantQuirks):
* Source/WebCore/page/Quirks.h:
* Source/WebCore/page/QuirksData.h:

Canonical link: https://commits.webkit.org/296749@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to