Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9c0ad024d332b98213d64cff313f79e0cb1832af
https://github.com/WebKit/WebKit/commit/9c0ad024d332b98213d64cff313f79e0cb1832af
Author: Sam Weinig <[email protected]>
Date: 2025-06-30 (Mon, 30 Jun 2025)
Changed paths:
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/style/values/borders/StyleShadow.h
Log Message:
-----------
[Style] Move shadow extent functions out of RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=295181
Reviewed by Simon Fraser.
RenderStyle already has enough going on, it doesn't need random extent
calculation functions.
Removes all the `RenderStyle::get*Shadow*Extent()` functions and replaces
them with Style::shadowBlockDirectionExtent/Style::shadowInlineDirectionExtent
which take any shadow type and a writing direction and compute the pair of
extents. While doing this, we also remove the "get" prefixes and switch to
pair return values rather than passing the output by reference.
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
* Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
* Source/WebCore/rendering/RenderBox.cpp:
* Source/WebCore/rendering/RenderElement.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::boxShadowExtent const): Deleted.
(WebCore::RenderStyle::boxShadowInsetExtent const): Deleted.
(WebCore::RenderStyle::getBoxShadowBlockDirectionExtent const): Deleted.
(WebCore::RenderStyle::getBoxShadowHorizontalExtent const): Deleted.
(WebCore::RenderStyle::getBoxShadowInlineDirectionExtent const): Deleted.
(WebCore::RenderStyle::getBoxShadowVerticalExtent const): Deleted.
(WebCore::RenderStyle::getTextShadowBlockDirectionExtent const): Deleted.
(WebCore::RenderStyle::getTextShadowHorizontalExtent const): Deleted.
(WebCore::RenderStyle::getTextShadowInlineDirectionExtent const): Deleted.
(WebCore::RenderStyle::getTextShadowVerticalExtent const): Deleted.
(WebCore::RenderStyle::textShadowExtent const): Deleted.
(WebCore::RenderStyle::getShadowHorizontalExtent): Deleted.
(WebCore::RenderStyle::getShadowVerticalExtent): Deleted.
(WebCore::RenderStyle::getShadowInlineDirectionExtent const): Deleted.
(WebCore::RenderStyle::getShadowBlockDirectionExtent const): Deleted.
* Source/WebCore/style/values/borders/StyleShadow.h:
(WebCore::Style::shadowHorizontalExtent):
(WebCore::Style::shadowVerticalExtent):
(WebCore::Style::shadowBlockDirectionExtent): Added.
(WebCore::Style::shadowInlineDirectionExtent): Added.
(WebCore::Style::getShadowHorizontalExtent): Renamed to shadowHorizontalExtent.
(WebCore::Style::getShadowVerticalExtent): Renamed to shadowVerticalExtent.
Canonical link: https://commits.webkit.org/296818@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
