Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e13b3de61a09946b762d6f583869691a33c0705
      
https://github.com/WebKit/WebKit/commit/1e13b3de61a09946b762d6f583869691a33c0705
  Author: Matt Woodrow <[email protected]>
  Date:   2025-06-30 (Mon, 30 Jun 2025)

  Changed paths:
    A 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/filter-with-mix-blend-mode-expected.html
    A 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/filter-with-mix-blend-mode.html
    M Source/WebCore/rendering/RenderLayer.cpp

  Log Message:
  -----------
  Content with a grayscale filter and mix-blend-mode don't get mix-blend-mode 
applied.
https://bugs.webkit.org/show_bug.cgi?id=293903
<rdar://152460888>

Reviewed by Simon Fraser.

Some filter types (including grayscale) are implemented by pushing a
transparency layer, rather than diverting to a temporary context.

In those cases, the code attempting to setup a transparency layer for opacity
(and mix-blend-mode) ends up doing so too late, and applies the mix-blend-mode
inside the filter (where it has nothing to blend with).

Move this up to before the filter is setup, so that the ordering is always
correct.

* 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/filter-with-mix-blend-mode-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/filter-with-mix-blend-mode.html:
 Added.
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):

Canonical link: https://commits.webkit.org/296827@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to