Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 53141a7f44a0310766ee093e2f26360731ca9e7e
https://github.com/WebKit/WebKit/commit/53141a7f44a0310766ee093e2f26360731ca9e7e
Author: Elliott Williams <e...@apple.com>
Date: 2025-07-01 (Tue, 01 Jul 2025)
Changed paths:
M Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb.py
M Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb_unittest.py
Log Message:
-----------
[webkitapipy] sdkdb foreign key constraints not in use
https://bugs.webkit.org/show_bug.cgi?id=295255
Reviewed by Sam Sneddon.
When I added windowing logic in 296448@main to allow a single sdkdb
cache to be used to check different projects and configurations, I
failed to actually enable foreign key constraints in the underlying
database. So the select logic worked, but the ON CASCADE DELETE logic
which cleans up old entries when an input file is updated never worked.
Fix that, and fix another path normalization bug: In 296638@main, we
missed a couple places where Path.absolute() was being used and needs to
change to resolve().
Add unit tests for the code paths affected by these bugs.
* Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb.py:
(SDKDB.__init__):
(SDKDB._initialize_temporary_schema):
(SDKDB._cache_hit_preparing_to_insert):
(SDKDB._add_symbol):
(SDKDB._add_objc_class.VALUES):
(SDKDB._add_objc_class):
(SDKDB._add_objc_selector):
* Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb_unittest.py:
(TestSDKDB.test_ingests_api_report_nonnormalized):
(TestSDKDB.test_path_normalized_when_cache_miss):
(TestSDKDB):
(TestSDKDB.test_entries_removed_when_binary_updated):
Canonical link: https://commits.webkit.org/296875@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
