Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77ba7337d7cdd989edca5358355aeaf95a2d5f06
      
https://github.com/WebKit/WebKit/commit/77ba7337d7cdd989edca5358355aeaf95a2d5f06
  Author: Lily Spiniolas <lily_spinio...@apple.com>
  Date:   2025-07-02 (Wed, 02 Jul 2025)

  Changed paths:
    A 
LayoutTests/fast/forms/select/select-focus-ring-is-not-clipped-expected-mismatch.html
    A LayoutTests/fast/forms/select/select-focus-ring-is-not-clipped.html
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderTheme.h
    M Source/WebCore/rendering/cocoa/RenderThemeCocoa.h
    M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm

  Log Message:
  -----------
  [Form Control Refresh] Focus ring clipped for native <select> buttons
https://bugs.webkit.org/show_bug.cgi?id=295256
rdar://154729412

Reviewed by Aditya Keerthi.

After 296129@main, native select buttons no longer had their border
radius reset, causing bleed avoidance to apply which resulted in the
focus ring getting clipped.

With these changes, bleed avoidance (except when handled directly by
the theme) no longer applies to any painted control.

* 
LayoutTests/fast/forms/select/select-focus-ring-is-not-clipped-expected-mismatch.html:
 Added.
* LayoutTests/fast/forms/select/select-focus-ring-is-not-clipped.html: Added.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::determineBleedAvoidance const):
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::mayNeedBleedAvoidance const):
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::mayNeedBleedAvoidance const):

Canonical link: https://commits.webkit.org/296951@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to