Title: [112951] trunk/Tools
- Revision
- 112951
- Author
- [email protected]
- Date
- 2012-04-02 15:19:32 -0700 (Mon, 02 Apr 2012)
Log Message
garden-o-matic should let you listen to audio failures
https://bugs.webkit.org/show_bug.cgi?id=82953
Reviewed by Chris Rogers.
Now that we've actually got an audio failure on the bots, we can clean
up the last stray bugs. This patch doesn't have any tests because I'm
lame.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
(.):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html (112950 => 112951)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html 2012-04-02 22:11:51 UTC (rev 112950)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html 2012-04-02 22:19:32 UTC (rev 112951)
@@ -33,6 +33,7 @@
style-src 'self' 'unsafe-inline' file: https://ajax.googleapis.com http://fonts.googleapis.com;
font-src http://themes.googleusercontent.com;
img-src https://ajax.googleapis.com http://build.chromium.org file:;
+ media-src http://build.chromium.org;
frame-src http://build.chromium.org;
connect-src http://trac.webkit.org http://build.chromium.org http://127.0.0.1:8127">
<title>Garden-O-Matic</title>
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js (112950 => 112951)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js 2012-04-02 22:11:51 UTC (rev 112950)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js 2012-04-02 22:19:32 UTC (rev 112951)
@@ -79,7 +79,7 @@
// Types of tests.
results.kImageType = 'image'
-results.kTextType = 'audio'
+results.kAudioType = 'audio'
results.kTextType = 'text'
// FIXME: There are more types of tests.
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js (112950 => 112951)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2012-04-02 22:11:51 UTC (rev 112950)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2012-04-02 22:19:32 UTC (rev 112951)
@@ -78,9 +78,22 @@
}
});
+ui.results.AudioResult = base.extends('audio', {
+ init: function(url)
+ {
+ this.className = 'audio-result';
+ this.src = ""
+ this.controls = 'controls';
+ }
+});
+
function constructorForResultType(type)
{
- return (type == results.kImageType) ? ui.results.ImageResult : ui.results.TextResult;
+ if (type == results.kImageType)
+ return ui.results.ImageResult;
+ if (type == results.kAudioType)
+ return ui.results.AudioResult;
+ return ui.results.TextResult;
}
ui.results.ResultsGrid = base.extends('div', {
@@ -119,6 +132,7 @@
var resultsURLsByTypeAndKind = {};
resultsURLsByTypeAndKind[results.kImageType] = {};
+ resultsURLsByTypeAndKind[results.kAudioType] = {};
resultsURLsByTypeAndKind[results.kTextType] = {};
resultsURLs.forEach(function(url) {
Modified: trunk/Tools/ChangeLog (112950 => 112951)
--- trunk/Tools/ChangeLog 2012-04-02 22:11:51 UTC (rev 112950)
+++ trunk/Tools/ChangeLog 2012-04-02 22:19:32 UTC (rev 112951)
@@ -1,3 +1,19 @@
+2012-04-02 Adam Barth <[email protected]>
+
+ garden-o-matic should let you listen to audio failures
+ https://bugs.webkit.org/show_bug.cgi?id=82953
+
+ Reviewed by Chris Rogers.
+
+ Now that we've actually got an audio failure on the bots, we can clean
+ up the last stray bugs. This patch doesn't have any tests because I'm
+ lame.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
+ (.):
+
2012-04-02 Stephanie Lewis <[email protected]>
run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
