Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7783e92f3779f982b6c57caabf3a52114421a41b
https://github.com/WebKit/WebKit/commit/7783e92f3779f982b6c57caabf3a52114421a41b
Author: Wenson Hsieh <[email protected]>
Date: 2025-07-04 (Fri, 04 Jul 2025)
Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm
M Tools/TestRunnerShared/spi/AppKitTestSPI.h
M Tools/TestWebKitAPI/mac/TestDraggingInfo.mm
Log Message:
-----------
[macOS Tahoe] 8 editing/pasteboard tests consistently time out when creating
NSDraggingItem
https://bugs.webkit.org/show_bug.cgi?id=295470
rdar://154992256
Reviewed by Abrar Rahman Protyasha.
In macOS 26, `-[NSDraggingItem _initWithItem:]` was renamed to
`-_initWithPasteboardItem:localItem:`
as a part of the refactoring in rdar://114847120, which causes layout tests
that use
`-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:...:]` to fail
when attempting to
create an `NSDraggingItem`. Because DumpRenderTree catches ObjC exceptions,
this results in a
timeout as the enumeration block parameter is never invoked.
Fix this by using `-_initWithPasteboardItem:localItem:` on macOS Tahoe.
* Source/WTF/wtf/PlatformHave.h:
* Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
(-[DumpRenderTreeDraggingInfo
enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
* Tools/TestRunnerShared/spi/AppKitTestSPI.h:
* Tools/TestWebKitAPI/mac/TestDraggingInfo.mm:
(-[TestDraggingInfo
enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
Also replace this call site of `-_initWithItem:`.
Canonical link: https://commits.webkit.org/297030@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
