Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2db6f72f6cd4dbf54841752031b1e9c40981d8d
      
https://github.com/WebKit/WebKit/commit/c2db6f72f6cd4dbf54841752031b1e9c40981d8d
  Author: Sergio Villar Senin <[email protected]>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M Source/WebKit/UIProcess/XR/openxr/PlatformXROpenXR.cpp
    M Source/WebKit/UIProcess/XR/openxr/PlatformXROpenXR.h

  Log Message:
  -----------
  [WebXR][OpenXR] XR_ERROR_SESSION_NOT_RUNNING issued sometimes when starting 
XR sessions
https://bugs.webkit.org/show_bug.cgi?id=295526

Reviewed by Carlos Garcia Campos.

Added a boolean attribute that tracks the readiness status of a session.
It's true only after the session enters the READY state, and becomes
false after moving to STOPPING state (it's also the default value).

This way we wouldn't run xrWaitFrame->xrBeginFrame->xrEndFrame sequence
on sessions that are not ready. That could happen if WebXR is able to set
a callback for onFrameUpdate to the UI process before the OpenXR runtime
is able to begin the session.

* Source/WebKit/UIProcess/XR/openxr/PlatformXROpenXR.cpp:
(WebKit::OpenXRCoordinator::handleSessionStateChange):
(WebKit::OpenXRCoordinator::renderLoop):
* Source/WebKit/UIProcess/XR/openxr/PlatformXROpenXR.h:

Canonical link: https://commits.webkit.org/297102@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to