Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 233a9daa785641cbe7ecf39e768f8318b31c7335
      
https://github.com/WebKit/WebKit/commit/233a9daa785641cbe7ecf39e768f8318b31c7335
  Author: Anne van Kesteren <[email protected]>
  Date:   2025-07-08 (Tue, 08 Jul 2025)

  Changed paths:
    M Source/WebKit/Platform/IPC/StreamClientConnection.cpp
    M Source/WebKit/Platform/IPC/StreamClientConnection.h
    M Source/WebKit/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  -----------
  Reduce unsafeness in StreamClientConnection and WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=295486

Reviewed by Chris Dumez and Rupin Mittal.

Apply https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines

* Source/WebKit/Platform/IPC/StreamClientConnection.h:
(IPC::StreamClientConnection::trySendSyncStream):

m_connection is a const Ref and therefore does not need stack protection.

* Source/WebKit/UIProcess/mac/WebViewImpl.mm:

All equivalent interfaces with member pointing to a WebKit::WebViewImpl
already have it as WeakPtr so it seems these were an oversight.

Canonical link: https://commits.webkit.org/297113@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to