Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 276b1deb070bc5b2a055dd8b301908af8bf62e08
https://github.com/WebKit/WebKit/commit/276b1deb070bc5b2a055dd8b301908af8bf62e08
Author: Chris Dumez <[email protected]>
Date: 2025-07-09 (Wed, 09 Jul 2025)
Changed paths:
M Source/JavaScriptCore/heap/Heap.h
M Source/JavaScriptCore/runtime/FunctionExecutable.h
M Source/WTF/wtf/ApproximateTime.h
M Source/WTF/wtf/ContinuousApproximateTime.h
M Source/WTF/wtf/ContinuousTime.h
M Source/WTF/wtf/Forward.h
M Source/WTF/wtf/Markable.h
M Source/WTF/wtf/MonotonicTime.h
M Source/WTF/wtf/ObjectIdentifier.h
M Source/WTF/wtf/Seconds.h
M Source/WTF/wtf/UUID.h
M Source/WTF/wtf/WallTime.h
M Source/WebCore/animation/AnimationEffectTiming.h
M Source/WebCore/animation/AnimationEventBase.h
M Source/WebCore/animation/AnimationTimelinesController.h
M Source/WebCore/animation/ComputedEffectTiming.h
M Source/WebCore/animation/FillMode.h
M Source/WebCore/animation/OptionalEffectTiming.h
M Source/WebCore/animation/PlaybackDirection.h
M Source/WebCore/animation/WebAnimation.h
M Source/WebCore/animation/WebAnimationTypes.h
M Source/WebCore/css/typedom/numeric/CSSNumericType.h
M Source/WebCore/css/values/color/CSSColor.cpp
M Source/WebCore/css/values/color/CSSColor.h
M Source/WebCore/css/values/primitives/CSSPrimitiveNumeric.h
M Source/WebCore/css/values/primitives/CSSPrimitiveNumericOrKeyword.h
M Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes.h
M Source/WebCore/dom/ElementRareData.cpp
M Source/WebCore/dom/ElementRareData.h
M Source/WebCore/dom/NodeWithIndex.h
M Source/WebCore/fileapi/URLKeepingBlobAlive.h
M Source/WebCore/html/HTMLAnchorElement.h
M Source/WebCore/html/LinkRelAttribute.h
M Source/WebCore/loader/ResourceLoaderOptions.h
M Source/WebCore/page/SecurityOriginData.h
M Source/WebCore/page/csp/ContentSecurityPolicyResponseHeaders.h
M Source/WebCore/platform/LayoutUnit.h
M Source/WebCore/platform/Length.h
M Source/WebCore/platform/ProcessQualified.h
M Source/WebCore/platform/ScriptExecutionContextIdentifier.h
M Source/WebCore/platform/SharedStringHash.h
M Source/WebCore/platform/animation/Animation.h
M Source/WebCore/platform/graphics/FloatPoint.h
M Source/WebCore/platform/graphics/FloatRect.h
M Source/WebCore/platform/graphics/FloatSize.h
M Source/WebCore/platform/graphics/FontMetrics.h
M Source/WebCore/platform/graphics/FontSizeAdjust.h
M Source/WebCore/platform/network/CacheValidation.h
M Source/WebCore/platform/network/ParsedContentRange.h
M Source/WebCore/platform/network/ResourceResponseBase.h
M Source/WebCore/platform/text/TextFlags.h
M Source/WebCore/rendering/RenderText.h
M Source/WebCore/rendering/style/ScrollbarColor.h
M Source/WebCore/rendering/svg/RenderSVGContainer.h
M Source/WebCore/rendering/svg/RenderSVGRoot.h
M Source/WebCore/rendering/svg/RenderSVGShape.h
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.h
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.h
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.h
M Source/WebCore/style/StyleExtractorConverter.h
M Source/WebCore/style/StyleExtractorSerializer.h
M Source/WebCore/style/values/color/StyleColor.cpp
M Source/WebCore/style/values/color/StyleColor.h
M Source/WebCore/style/values/primitives/StylePrimitiveNumeric.h
M Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes.h
M Source/WebCore/workers/service/background-fetch/BackgroundFetchManager.cpp
M Source/WebCore/workers/service/background-fetch/BackgroundFetchRequest.h
M Source/WebGPU/WGSL/Types.h
M Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h
M
Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.serialization.in
M Source/WebKit/Shared/WebHitTestResultData.h
M Source/WebKit/Shared/WebProcessCreationParameters.h
M Source/WebKit/Shared/WebProcessCreationParameters.serialization.in
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h
M Tools/TestWebKitAPI/Tests/WebCore/FloatPointTests.cpp
M Tools/TestWebKitAPI/Tests/WebCore/FloatRectTests.cpp
M Tools/TestWebKitAPI/Tests/WebCore/FloatSizeTests.cpp
Log Message:
-----------
Use template specializations for Markable Traits
https://bugs.webkit.org/show_bug.cgi?id=295592
Reviewed by Darin Adler and Dan Glastonbury.
Use template specialization for Markable Traits. This avoids having to
specify the second template parameter for Markable in more cases.
* Source/JavaScriptCore/heap/Heap.h:
* Source/JavaScriptCore/runtime/FunctionExecutable.h:
* Source/WTF/wtf/ApproximateTime.h:
(WTF::ApproximateTime::MarkableTraits::isEmptyValue): Deleted.
(WTF::ApproximateTime::MarkableTraits::emptyValue): Deleted.
* Source/WTF/wtf/ContinuousApproximateTime.h:
(WTF::ContinuousApproximateTime::MarkableTraits::isEmptyValue): Deleted.
(WTF::ContinuousApproximateTime::MarkableTraits::emptyValue): Deleted.
* Source/WTF/wtf/ContinuousTime.h:
(WTF::ContinuousTime::MarkableTraits::isEmptyValue): Deleted.
(WTF::ContinuousTime::MarkableTraits::emptyValue): Deleted.
* Source/WTF/wtf/Forward.h:
* Source/WTF/wtf/Markable.h:
(WTF::MarkableTraits<T>::isEmptyValue):
(WTF::MarkableTraits<T>::emptyValue):
(WTF::FloatMarkableTraits::isEmptyValue): Deleted.
(WTF::FloatMarkableTraits::emptyValue): Deleted.
* Source/WTF/wtf/MonotonicTime.h:
(WTF::MonotonicTime::MarkableTraits::isEmptyValue): Deleted.
(WTF::MonotonicTime::MarkableTraits::emptyValue): Deleted.
* Source/WTF/wtf/ObjectIdentifier.h:
(WTF::ObjectIdentifierGeneric::MarkableTraits::isEmptyValue): Deleted.
(WTF::ObjectIdentifierGeneric::MarkableTraits::emptyValue): Deleted.
* Source/WTF/wtf/Seconds.h:
(WTF::Seconds::MarkableTraits::isEmptyValue): Deleted.
(WTF::Seconds::MarkableTraits::emptyValue): Deleted.
* Source/WTF/wtf/UUID.h:
(WTF::MarkableTraits<UUID>::isEmptyValue):
(WTF::MarkableTraits<UUID>::emptyValue):
(WTF::UUID::MarkableTraits::isEmptyValue): Deleted.
(WTF::UUID::MarkableTraits::emptyValue): Deleted.
* Source/WTF/wtf/WallTime.h:
(WTF::WallTime::MarkableTraits::isEmptyValue): Deleted.
(WTF::WallTime::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/animation/AnimationEffectTiming.h:
* Source/WebCore/animation/AnimationEventBase.h:
* Source/WebCore/animation/AnimationTimelinesController.h:
* Source/WebCore/animation/ComputedEffectTiming.h:
* Source/WebCore/animation/FillMode.h:
* Source/WebCore/animation/OptionalEffectTiming.h:
* Source/WebCore/animation/PlaybackDirection.h:
* Source/WebCore/animation/WebAnimation.h:
* Source/WebCore/animation/WebAnimationTypes.h:
(WebCore::WebAnimationsMarkableDoubleTraits::isEmptyValue): Deleted.
(WebCore::WebAnimationsMarkableDoubleTraits::emptyValue): Deleted.
* Source/WebCore/css/typedom/numeric/CSSNumericType.h:
* Source/WebCore/css/values/color/CSSColor.cpp:
(WebCore::CSS::Color::MarkableTraits::isEmptyValue): Deleted.
(WebCore::CSS::Color::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/css/values/color/CSSColor.h:
(WTF::MarkableTraits<WebCore::CSS::Color>::isEmptyValue):
(WTF::MarkableTraits<WebCore::CSS::Color>::emptyValue):
* Source/WebCore/css/values/primitives/CSSPrimitiveNumeric.h:
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericOrKeyword.h:
(WebCore::CSS::PrimitiveNumericOrKeyword::MarkableTraits::isEmptyValue):
Deleted.
(WebCore::CSS::PrimitiveNumericOrKeyword::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes.h:
(WebCore::CSS::NumberOrPercentage::MarkableTraits::isEmptyValue): Deleted.
(WebCore::CSS::NumberOrPercentage::MarkableTraits::emptyValue): Deleted.
(WebCore::CSS::NumberOrPercentageResolvedToNumber::MarkableTraits::isEmptyValue):
Deleted.
(WebCore::CSS::NumberOrPercentageResolvedToNumber::MarkableTraits::emptyValue):
Deleted.
* Source/WebCore/dom/ElementRareData.cpp:
* Source/WebCore/dom/ElementRareData.h:
(WebCore::LayoutUnitMarkableTraits::isEmptyValue): Deleted.
(WebCore::LayoutUnitMarkableTraits::emptyValue): Deleted.
* Source/WebCore/dom/NodeWithIndex.h:
* Source/WebCore/fileapi/URLKeepingBlobAlive.h:
* Source/WebCore/html/HTMLAnchorElement.h:
* Source/WebCore/html/LinkRelAttribute.h:
* Source/WebCore/loader/ResourceLoaderOptions.h:
* Source/WebCore/page/SecurityOriginData.h:
(WTF::MarkableTraits<WebCore::SecurityOriginData>::isEmptyValue):
(WTF::MarkableTraits<WebCore::SecurityOriginData>::emptyValue):
(WebCore::SecurityOriginDataMarkableTraits::isEmptyValue): Deleted.
(WebCore::SecurityOriginDataMarkableTraits::emptyValue): Deleted.
* Source/WebCore/page/csp/ContentSecurityPolicyResponseHeaders.h:
(WTF::MarkableTraits<WebCore::ContentSecurityPolicyResponseHeaders>::isEmptyValue):
(WTF::MarkableTraits<WebCore::ContentSecurityPolicyResponseHeaders>::emptyValue):
(WebCore::ContentSecurityPolicyResponseHeaders::MarkableTraits::isEmptyValue):
Deleted.
(WebCore::ContentSecurityPolicyResponseHeaders::MarkableTraits::emptyValue):
Deleted.
* Source/WebCore/platform/LayoutUnit.h:
(WTF::MarkableTraits<WebCore::LayoutUnit>::isEmptyValue):
(WTF::MarkableTraits<WebCore::LayoutUnit>::emptyValue):
* Source/WebCore/platform/Length.h:
(WTF::MarkableTraits<WebCore::Length>::isEmptyValue):
(WTF::MarkableTraits<WebCore::Length>::emptyValue):
(WebCore::Length::MarkableTraits::isEmptyValue): Deleted.
(WebCore::Length::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/platform/ProcessQualified.h:
(WTF::MarkableTraits<WebCore::ProcessQualified<T>>::isEmptyValue):
(WTF::MarkableTraits<WebCore::ProcessQualified<T>>::emptyValue):
(WebCore::ProcessQualified::MarkableTraits::isEmptyValue): Deleted.
(WebCore::ProcessQualified::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/platform/ScriptExecutionContextIdentifier.h:
(WTF::MarkableTraits<WebCore::ProcessQualified<UUID>>::isEmptyValue):
(WTF::MarkableTraits<WebCore::ProcessQualified<UUID>>::emptyValue):
(WebCore::ProcessQualified<WTF::UUID>::MarkableTraits::isEmptyValue): Deleted.
(WebCore::ProcessQualified<WTF::UUID>::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/platform/SharedStringHash.h:
* Source/WebCore/platform/animation/Animation.h:
(WebCore::Animation::duration const):
(WebCore::Animation::setDuration):
(WebCore::Animation::fillDuration):
(WebCore::Animation::initialDuration):
* Source/WebCore/platform/graphics/FloatPoint.h:
(WTF::MarkableTraits<WebCore::FloatPoint>::isEmptyValue):
(WTF::MarkableTraits<WebCore::FloatPoint>::emptyValue):
(WebCore::FloatPoint::MarkableTraits::isEmptyValue): Deleted.
(WebCore::FloatPoint::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/platform/graphics/FloatRect.h:
(WTF::MarkableTraits<WebCore::FloatRect>::isEmptyValue):
(WTF::MarkableTraits<WebCore::FloatRect>::emptyValue):
(WebCore::FloatRect::MarkableTraits::isEmptyValue): Deleted.
(WebCore::FloatRect::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/platform/graphics/FloatSize.h:
(WTF::MarkableTraits<WebCore::FloatSize>::isEmptyValue):
(WTF::MarkableTraits<WebCore::FloatSize>::emptyValue):
(WebCore::FloatSize::MarkableTraits::isEmptyValue): Deleted.
(WebCore::FloatSize::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/platform/graphics/FontMetrics.h:
(WebCore::FontMetrics::xHeight const):
(WebCore::FontMetrics::capHeight const):
(WebCore::FontMetrics::zeroWidth const):
(WebCore::FontMetrics::ideogramWidth const):
(WebCore::FontMetrics::underlinePosition const):
(WebCore::FontMetrics::underlineThickness const):
(WebCore::FontMetrics::MarkableTraits::isEmptyValue): Deleted.
(WebCore::FontMetrics::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/platform/graphics/FontSizeAdjust.h:
* Source/WebCore/platform/network/CacheValidation.h:
* Source/WebCore/platform/network/ParsedContentRange.h:
(WTF::MarkableTraits<WebCore::ParsedContentRange>::isEmptyValue):
(WTF::MarkableTraits<WebCore::ParsedContentRange>::emptyValue):
(WebCore::ParsedContentRange::MarkableTraits::isEmptyValue): Deleted.
(WebCore::ParsedContentRange::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/platform/network/ResourceResponseBase.h:
* Source/WebCore/platform/text/TextFlags.h:
(WTF::MarkableTraits<WebCore::FontVariantAlternatesValues>::isEmptyValue):
(WTF::MarkableTraits<WebCore::FontVariantAlternatesValues>::emptyValue):
(WebCore::FontVariantAlternatesValues::MarkableTraits::isEmptyValue): Deleted.
(WebCore::FontVariantAlternatesValues::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/rendering/RenderText.h:
* Source/WebCore/rendering/style/ScrollbarColor.h:
(WTF::MarkableTraits<WebCore::ScrollbarColor>::isEmptyValue):
(WTF::MarkableTraits<WebCore::ScrollbarColor>::emptyValue):
(WebCore::ScrollbarColor::MarkableTraits::isEmptyValue): Deleted.
(WebCore::ScrollbarColor::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/rendering/svg/RenderSVGContainer.h:
* Source/WebCore/rendering/svg/RenderSVGRoot.h:
* Source/WebCore/rendering/svg/RenderSVGShape.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.h:
* Source/WebCore/style/StyleExtractorConverter.h:
(WebCore::Style::ExtractorConverter::convertAnimationDuration):
* Source/WebCore/style/StyleExtractorSerializer.h:
(WebCore::Style::ExtractorSerializer::serializeAnimationDuration):
* Source/WebCore/style/values/color/StyleColor.cpp:
(WebCore::Style::Color::MarkableTraits::isEmptyValue): Deleted.
(WebCore::Style::Color::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/style/values/color/StyleColor.h:
(WTF::MarkableTraits<WebCore::Style::Color>::isEmptyValue):
(WTF::MarkableTraits<WebCore::Style::Color>::emptyValue):
* Source/WebCore/style/values/primitives/StylePrimitiveNumeric.h:
* Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes.h:
(WebCore::Style::NumberOrPercentage::MarkableTraits::isEmptyValue): Deleted.
(WebCore::Style::NumberOrPercentage::MarkableTraits::emptyValue): Deleted.
* Source/WebCore/workers/service/background-fetch/BackgroundFetchManager.cpp:
(WebCore::BackgroundFetchManager::fetch):
* Source/WebCore/workers/service/background-fetch/BackgroundFetchRequest.h:
* Source/WebGPU/WGSL/Types.h:
* Source/WebKit/Shared/WebHitTestResultData.h:
(WTF::MarkableTraits<WebKit::WebHitTestResultPlatformData::DetectedDataActionContext>::isEmptyValue):
(WTF::MarkableTraits<WebKit::WebHitTestResultPlatformData::DetectedDataActionContext>::emptyValue):
(WebKit::WebHitTestResultPlatformData::DetectedDataActionContext::MarkableTraits::isEmptyValue):
Deleted.
(WebKit::WebHitTestResultPlatformData::DetectedDataActionContext::MarkableTraits::emptyValue):
Deleted.
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h:
* Tools/TestWebKitAPI/Tests/WebCore/FloatPointTests.cpp:
(TestWebKitAPI::TEST(FloatPoint, Markable)):
* Tools/TestWebKitAPI/Tests/WebCore/FloatRectTests.cpp:
(TestWebKitAPI::TEST(FloatRect, Markable)):
* Tools/TestWebKitAPI/Tests/WebCore/FloatSizeTests.cpp:
(TestWebKitAPI::TEST(FloatSize, Markable)):
Canonical link: https://commits.webkit.org/297154@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
