Title: [112995] trunk/Tools
- Revision
- 112995
- Author
- [email protected]
- Date
- 2012-04-03 01:32:34 -0700 (Tue, 03 Apr 2012)
Log Message
rebaseline-server: Make it possible to not launch a browser with the server.
https://bugs.webkit.org/show_bug.cgi?id=82999
Reviewed by Adam Barth.
Add the `--no-show-results' option, which lets one decide not to
launch a web browser when running the rebaseline server. This is
especially useful if the default browser is not the wanted one, or
if the rebaseline server page is already open.
* Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
(AbstractLocalServerCommand.__init__):
(AbstractLocalServerCommand.execute):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (112994 => 112995)
--- trunk/Tools/ChangeLog 2012-04-03 08:28:37 UTC (rev 112994)
+++ trunk/Tools/ChangeLog 2012-04-03 08:32:34 UTC (rev 112995)
@@ -1,3 +1,19 @@
+2012-04-03 Raphael Kubo da Costa <[email protected]>
+
+ rebaseline-server: Make it possible to not launch a browser with the server.
+ https://bugs.webkit.org/show_bug.cgi?id=82999
+
+ Reviewed by Adam Barth.
+
+ Add the `--no-show-results' option, which lets one decide not to
+ launch a web browser when running the rebaseline server. This is
+ especially useful if the default browser is not the wanted one, or
+ if the rebaseline server page is already open.
+
+ * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
+ (AbstractLocalServerCommand.__init__):
+ (AbstractLocalServerCommand.execute):
+
2012-04-02 Mikhail Pozdnyakov <[email protected]>
EFL's LayoutTestController disableImageLoading implementation.
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py (112994 => 112995)
--- trunk/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py 2012-04-03 08:28:37 UTC (rev 112994)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py 2012-04-03 08:32:34 UTC (rev 112995)
@@ -35,6 +35,7 @@
def __init__(self):
options = [
make_option("--httpd-port", action="" type="int", default=8127, help="Port to use for the HTTP server"),
+ make_option("--no-show-results", action="" default=True, dest="show_results", help="Don't launch a browser with the rebaseline server"),
]
AbstractDeclarativeCommand.__init__(self, options=options)
@@ -48,8 +49,9 @@
print "Starting server at %s" % server_url
print "Use the 'Exit' link in the UI, %squitquitquit or Ctrl-C to stop" % server_url
- # FIXME: This seems racy.
- threading.Timer(0.1, lambda: self._tool.user.open_url(server_url)).start()
+ if options.show_results:
+ # FIXME: This seems racy.
+ threading.Timer(0.1, lambda: self._tool.user.open_url(server_url)).start()
httpd = self.server(httpd_port=options.httpd_port, config=config)
httpd.serve_forever()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
