Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d502356fa563b7f5ff948b70bfbded412a263468
https://github.com/WebKit/WebKit/commit/d502356fa563b7f5ff948b70bfbded412a263468
Author: Alan Baradlay <[email protected]>
Date: 2025-07-15 (Tue, 15 Jul 2025)
Changed paths:
M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp
M Source/WebCore/rendering/RenderAttachment.cpp
M Source/WebCore/rendering/RenderAttachment.h
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderButton.cpp
M Source/WebCore/rendering/RenderButton.h
M Source/WebCore/rendering/RenderFileUploadControl.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderImage.h
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderInline.h
M Source/WebCore/rendering/RenderLineBreak.cpp
M Source/WebCore/rendering/RenderLineBreak.h
M Source/WebCore/rendering/RenderListBox.cpp
M Source/WebCore/rendering/RenderListBox.h
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderListMarker.h
M Source/WebCore/rendering/RenderMenuList.h
M Source/WebCore/rendering/RenderSlider.cpp
M Source/WebCore/rendering/RenderSlider.h
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTable.h
M Source/WebCore/rendering/RenderTextControl.h
M Source/WebCore/rendering/RenderTextControlMultiLine.cpp
M Source/WebCore/rendering/RenderTextControlMultiLine.h
M Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
M Source/WebCore/rendering/mathml/RenderMathMLBlock.h
Log Message:
-----------
[Cleanup] RenderBoxModelObject::baselinePosition's LinePositionMode is unused
https://bugs.webkit.org/show_bug.cgi?id=295116
Reviewed by Antti Koivisto.
LinePositionMode is a legacy concept from when inline layout/paint/hittest
called into renderers to figure out their baselines.
There's only one place where we don't pass in PositionOnContainingLine (see
RenderListMarker) in which case RenderListItem anyway ignores the incoming
value and go strait to font metrics.
(also, again ever since IFC at the point when this function is called, we don't
have lines yet)
* Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp:
(WebCore::LayoutIntegration::setIntegrationBaseline):
* Source/WebCore/rendering/RenderAttachment.cpp:
(WebCore::RenderAttachment::baselinePosition const):
* Source/WebCore/rendering/RenderAttachment.h:
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::baselinePosition const):
* Source/WebCore/rendering/RenderBlock.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::baselinePosition const):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderButton.cpp:
(WebCore::RenderButton::baselinePosition const):
* Source/WebCore/rendering/RenderButton.h:
* Source/WebCore/rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintControl):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::baselinePosition const):
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::baselinePosition const):
* Source/WebCore/rendering/RenderGrid.h:
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::baselinePosition const):
* Source/WebCore/rendering/RenderImage.h:
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::baselinePosition const):
* Source/WebCore/rendering/RenderInline.h:
* Source/WebCore/rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::baselinePosition const):
* Source/WebCore/rendering/RenderLineBreak.h:
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::baselinePosition const):
* Source/WebCore/rendering/RenderListBox.h:
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::baselinePosition const):
* Source/WebCore/rendering/RenderListMarker.h:
* Source/WebCore/rendering/RenderMenuList.h:
* Source/WebCore/rendering/RenderSlider.cpp:
(WebCore::RenderSlider::baselinePosition const):
* Source/WebCore/rendering/RenderSlider.h:
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::baselinePosition const):
* Source/WebCore/rendering/RenderTable.h:
* Source/WebCore/rendering/RenderTextControl.h:
* Source/WebCore/rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::baselinePosition const):
* Source/WebCore/rendering/RenderTextControlMultiLine.h:
* Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::baselinePosition const):
* Source/WebCore/rendering/mathml/RenderMathMLBlock.h:
Canonical link: https://commits.webkit.org/297389@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
