Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d52459e42f870cd1b42ad406f87071f981944b70
https://github.com/WebKit/WebKit/commit/d52459e42f870cd1b42ad406f87071f981944b70
Author: Adrian Perez de Castro <ape...@igalia.com>
Date: 2025-07-16 (Wed, 16 Jul 2025)
Changed paths:
M Source/JavaScriptCore/jsc.cpp
M Source/WTF/wtf/Assertions.cpp
M Source/WTF/wtf/Assertions.h
M Source/WTF/wtf/Logger.h
M Source/WTF/wtf/PlatformWPE.cmake
M Source/WTF/wtf/WTFConfig.h
A Source/cmake/FindAndroid.cmake
M Source/cmake/OptionsWPE.cmake
Log Message:
-----------
[WPE] Log messages to the Android log where appropriate
https://bugs.webkit.org/show_bug.cgi?id=295155
Reviewed by Nikolas Zimmermann and Sergio Villar Senin.
Add an Android-specific version of the logging macros. Those use
__android_log_print() to get the messages sent to the system log
facility. LogChannel is also augmented with calls to the Android
logging functions where appropriate.
Also, on actual devices Android closes the standard error stream of
processes by default, therefore it is handy to have messages send to
the standard error stream forwarded to the system log.
In all cases, the name of the LogChannel subsystem is set as the
Android logging tag, which means that the corresponding system
property (i.e. "log.tag.<name>") needs to be set in order for logs
to be sent to the system log. This can be achieved for example with
the following command using ADB:
adb shell setprop log.tag.WPEWebKit VERBOSE
Or, to save the setting:
adb shell setprop persist.log.tag.WPEWebKit VERBOSE
The logging level may be set to VERBOSE, DEBUG, INFO, WARN, ERROR,
or FATAL. Those correspond to the log levels defined in <android/log.h>.
More information about how to configure the logger can be found at:
https://android.googlesource.com/platform/system/core/+/66607ebc0e451/logd/README.property
Setting environment variables on Android is a bit of a chore, so in
the future it may be desirable to read the list of enabled logging
channels from a system property instead.
* Source/JavaScriptCore/jsc.cpp:
(main):
* Source/WTF/wtf/Assertions.cpp:
* Source/WTF/wtf/Assertions.h:
* Source/WTF/wtf/Logger.h:
(WTF::Logger::willLog const):
(WTF::Logger::log):
(WTF::Logger::logVerbose):
* Source/WTF/wtf/PlatformWPE.cmake:
* Source/WTF/wtf/WTFConfig.h:
* Source/cmake/FindAndroid.cmake: Added.
* Source/cmake/OptionsWPE.cmake:
Canonical link: https://commits.webkit.org/297472@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
