Branch: refs/heads/webkitglib/2.48
Home: https://github.com/WebKit/WebKit
Commit: cf31e5f9d77e6ee4899dbbfb6ef6778803cd2ae6
https://github.com/WebKit/WebKit/commit/cf31e5f9d77e6ee4899dbbfb6ef6778803cd2ae6
Author: Adrian Perez de Castro <[email protected]>
Date: 2025-07-16 (Wed, 16 Jul 2025)
Changed paths:
M Source/JavaScriptCore/jsc.cpp
M Source/WTF/wtf/Assertions.cpp
M Source/WTF/wtf/Assertions.h
M Source/WTF/wtf/Logger.h
M Source/WTF/wtf/PlatformWPE.cmake
M Source/WTF/wtf/WTFConfig.h
A Source/cmake/FindAndroid.cmake
M Source/cmake/OptionsWPE.cmake
Log Message:
-----------
Cherry-pick 297472@main (d52459e42f87).
https://bugs.webkit.org/show_bug.cgi?id=295155
[WPE] Log messages to the Android log where appropriate
https://bugs.webkit.org/show_bug.cgi?id=295155
Reviewed by Nikolas Zimmermann and Sergio Villar Senin.
Add an Android-specific version of the logging macros. Those use
__android_log_print() to get the messages sent to the system log
facility. LogChannel is also augmented with calls to the Android
logging functions where appropriate.
Also, on actual devices Android closes the standard error stream of
processes by default, therefore it is handy to have messages send to
the standard error stream forwarded to the system log.
In all cases, the name of the LogChannel subsystem is set as the
Android logging tag, which means that the corresponding system
property (i.e. "log.tag.<name>") needs to be set in order for logs
to be sent to the system log. This can be achieved for example with
the following command using ADB:
adb shell setprop log.tag.WPEWebKit VERBOSE
Or, to save the setting:
adb shell setprop persist.log.tag.WPEWebKit VERBOSE
The logging level may be set to VERBOSE, DEBUG, INFO, WARN, ERROR,
or FATAL. Those correspond to the log levels defined in <android/log.h>.
More information about how to configure the logger can be found at:
https://android.googlesource.com/platform/system/core/+/66607ebc0e451/logd/README.property
Setting environment variables on Android is a bit of a chore, so in
the future it may be desirable to read the list of enabled logging
channels from a system property instead.
* Source/JavaScriptCore/jsc.cpp:
(main):
* Source/WTF/wtf/Assertions.cpp:
* Source/WTF/wtf/Assertions.h:
* Source/WTF/wtf/Logger.h:
(WTF::Logger::willLog const):
(WTF::Logger::log):
(WTF::Logger::logVerbose):
* Source/WTF/wtf/PlatformWPE.cmake:
* Source/WTF/wtf/WTFConfig.h:
* Source/cmake/FindAndroid.cmake: Added.
* Source/cmake/OptionsWPE.cmake:
Canonical link: https://commits.webkit.org/297472@main
Canonical link: https://commits.webkit.org/290945.280@webkitglib/2.48
Commit: 9281920391faa1f379141522749c43d0868b9a7b
https://github.com/WebKit/WebKit/commit/9281920391faa1f379141522749c43d0868b9a7b
Author: Adrian Perez de Castro <[email protected]>
Date: 2025-07-16 (Wed, 16 Jul 2025)
Changed paths:
M Source/WTF/wtf/PlatformWPE.cmake
A Source/WTF/wtf/android/LoggingAndroid.cpp
M Source/WTF/wtf/unix/LoggingUnix.cpp
Log Message:
-----------
Cherry-pick 297467@main (f8b520c6e9b1).
https://bugs.webkit.org/show_bug.cgi?id=295175
[WTF][WPE] Read the log level string from an Android system property
https://bugs.webkit.org/show_bug.cgi?id=295175
Reviewed by Nikolas Zimmermann and Michael Catanzaro.
Read the value of the debug.WPEWebKit.log system property to determine
the value returned by WTF::logLevelString() to configure logging
channels on Android.
This allows using the "setprop" command line tool to configure logging:
adb shell setprop debug.WPEWebKit.log 'Scrolling,Loading'
* Source/WTF/wtf/PlatformWPE.cmake:
* Source/WTF/wtf/android/LoggingAndroid.cpp: Copied from
Source/WTF/wtf/unix/LoggingUnix.cpp.
(WTF::logLevelString):
* Source/WTF/wtf/unix/LoggingUnix.cpp: Guard with !OS(ANDROID); remove
unneeded <string.h> header inclusion, and make logLevel "const" as
drive-by fixes.
(WTF::logLevelString):
Canonical link: https://commits.webkit.org/297467@main
Canonical link: https://commits.webkit.org/290945.281@webkitglib/2.48
Compare: https://github.com/WebKit/WebKit/compare/ac5765cc2a07...9281920391fa
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
