Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2d72924c6decf6fffba344a7fe8aca39d411cb06
https://github.com/WebKit/WebKit/commit/2d72924c6decf6fffba344a7fe8aca39d411cb06
Author: Sam Weinig <s...@webkit.org>
Date: 2025-07-17 (Thu, 17 Jul 2025)
Changed paths:
M Source/WebCore/CMakeLists.txt
M Source/WebCore/Headers.cmake
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/accessibility/AccessibilityList.cpp
M Source/WebCore/css/CSSCounterStyle.cpp
M Source/WebCore/css/CSSCounterStyle.h
M Source/WebCore/css/CSSCounterStyleRegistry.cpp
M Source/WebCore/css/CSSCounterStyleRegistry.h
M Source/WebCore/css/CSSCounterValue.cpp
M Source/WebCore/css/CSSCounterValue.h
M Source/WebCore/css/CSSPrimitiveValueMappings.h
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Content.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp
M Source/WebCore/editing/FontAttributes.h
M Source/WebCore/editing/cocoa/FontAttributesCocoa.mm
M Source/WebCore/rendering/RenderCounter.cpp
M Source/WebCore/rendering/RenderCounter.h
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/style/CounterContent.h
R Source/WebCore/rendering/style/ListStyleType.cpp
R Source/WebCore/rendering/style/ListStyleType.h
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
M Source/WebCore/rendering/style/StyleRareInheritedData.h
M Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp
M Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.h
M Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp
M Source/WebCore/style/StyleBuilderConverter.h
M Source/WebCore/style/StyleBuilderCustom.h
M Source/WebCore/style/StyleExtractorConverter.h
M Source/WebCore/style/StyleExtractorCustom.h
M Source/WebCore/style/StyleExtractorSerializer.h
A Source/WebCore/style/values/counter-styles/StyleCounterStyle.cpp
A Source/WebCore/style/values/counter-styles/StyleCounterStyle.h
A Source/WebCore/style/values/lists/StyleListStyleType.cpp
A Source/WebCore/style/values/lists/StyleListStyleType.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
Log Message:
-----------
[Style] Convert list-style-type to use strong style types
https://bugs.webkit.org/show_bug.cgi?id=296073
Reviewed by Tim Nguyen.
Updates the existing ListStyleType type to be a strong style type, adding
variant-like conformance to remove need for custom extractor and serialization.
Additional IPC specific construction was needed for WebKit's IPC coders.
ListStyleType was incorrectly being used by the counters code where a
CounterStyle (a subset of ListStyleType) was actually needed, so this also
adds a CounterStyle type and adopts it. This allowed the removal of a bunch
of assertions that are now impossible.
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/accessibility/AccessibilityList.cpp:
* Source/WebCore/css/CSSCounterStyle.cpp:
* Source/WebCore/css/CSSCounterStyle.h:
* Source/WebCore/css/CSSCounterStyleRegistry.cpp:
* Source/WebCore/css/CSSCounterStyleRegistry.h:
* Source/WebCore/css/CSSCounterValue.cpp:
* Source/WebCore/css/CSSCounterValue.h:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Content.cpp:
* Source/WebCore/editing/FontAttributes.h:
* Source/WebCore/editing/cocoa/FontAttributesCocoa.mm:
* Source/WebCore/rendering/RenderCounter.cpp:
* Source/WebCore/rendering/RenderCounter.h:
* Source/WebCore/rendering/RenderListMarker.cpp:
* Source/WebCore/rendering/style/CounterContent.h:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
* Source/WebCore/rendering/style/RenderStyleSetters.h:
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:
* Source/WebCore/style/StyleBuilderConverter.h:
* Source/WebCore/style/StyleBuilderCustom.h:
* Source/WebCore/style/StyleExtractorConverter.h:
* Source/WebCore/style/StyleExtractorCustom.h:
* Source/WebCore/style/StyleExtractorSerializer.h:
* Source/WebCore/style/values/counter-styles/StyleCounterStyle.cpp: Renamed
from Source/WebCore/rendering/style/ListStyleType.h.
* Source/WebCore/style/values/counter-styles/StyleCounterStyle.h: Renamed from
Source/WebCore/rendering/style/ListStyleType.cpp.
* Source/WebCore/style/values/lists/StyleListStyleType.cpp: Added.
* Source/WebCore/style/values/lists/StyleListStyleType.h: Added.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
Canonical link: https://commits.webkit.org/297551@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
