Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 607b0dd8d379f756d33bd9f1d3d7394517de820c
https://github.com/WebKit/WebKit/commit/607b0dd8d379f756d33bd9f1d3d7394517de820c
Author: Dominic Mazzoni <[email protected]>
Date: 2025-07-18 (Fri, 18 Jul 2025)
Changed paths:
A LayoutTests/accessibility/mac/invalid-list-box-valid-list-expected.txt
A LayoutTests/accessibility/mac/invalid-list-box-valid-list.html
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm
M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
Log Message:
-----------
AX: VoiceOver not announcing Entering or Leaving when navigating to or from a
ordered list as role=listbox
https://bugs.webkit.org/show_bug.cgi?id=296210
rdar://156178283
Reviewed by Tyler Wilcock.
According to the spec, role=listbox should only be used with role=option as
children. To avoid breakage when role=listbox was used incorrectly, we mapped
it to AXGroup if there are no options. However, this was probably too extreme
when it was put on a static list like a <ul> or <ol> element with list items
as children. Make sure it maps to a static list role in those cases.
* LayoutTests/accessibility/mac/invalid-list-box-valid-list-expected.txt: Added.
* LayoutTests/accessibility/mac/invalid-list-box-valid-list.html: Added.
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::listBoxInterpretation const):
(WebCore::AXCoreObject::isValidListBox const): Deleted.
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::AXCoreObject::isInvalidListBox const): Deleted.
* Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm:
(WebCore::AXCoreObject::rolePlatformString):
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::subrolePlatformString const):
Canonical link: https://commits.webkit.org/297634@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
