Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: baec4aed924e42ec28b55ec7d608cc13f7bdd9d1
https://github.com/WebKit/WebKit/commit/baec4aed924e42ec28b55ec7d608cc13f7bdd9d1
Author: Jer Noble <[email protected]>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M LayoutTests/fullscreen/fullscreen-enter-bottom-padding-animation.html
A
LayoutTests/fullscreen/fullscreen-zero-height-element-with-non-zero-children-expected.txt
A
LayoutTests/fullscreen/fullscreen-zero-height-element-with-non-zero-children.html
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
Log Message:
-----------
[macOS] Fullscreen animation on YouTube.com is missing
rdar://155498665
https://bugs.webkit.org/show_bug.cgi?id=296156
Reviewed by Andy Estes.
In 296331@main, we tried to use a different mechanism to calculate the visual
extents of the
element which was entering fullscreen, to account for overflow children of
zero-height contents.
However, this caused issues on sites like weather.com and hulu.com, where this
calculation lead
to buggy looking animations.
Instead, only use this more expansive screen rect calculation if
element.screenRect() returns
an empty rect.
*
LayoutTests/fullscreen/fullscreen-zero-height-element-with-non-zero-children-expected.txt:
Added.
*
LayoutTests/fullscreen/fullscreen-zero-height-element-with-non-zero-children.html:
Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::screenRectOfContents):
(WebKit::WebFullScreenManager::enterFullScreenForElement):
(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):
Canonical link: https://commits.webkit.org/297687@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
