Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af7d511da998e59d45f98ffd2575db47e4a0b4e6
      
https://github.com/WebKit/WebKit/commit/af7d511da998e59d45f98ffd2575db47e4a0b4e6
  Author: Chris Dumez <[email protected]>
  Date:   2025-07-22 (Tue, 22 Jul 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp
    M Source/WebKit/UIProcess/API/APIContentRuleListStore.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm

  Log Message:
  -----------
  Parallel calls to [WKContentRuleListStore 
compileContentRuleListForIdentifier:] for the same identifier can fail
https://bugs.webkit.org/show_bug.cgi?id=296313

Reviewed by Alex Christensen.

Parallel calls to [WKContentRuleListStore compileContentRuleListForIdentifier:] 
for
the same identifier can fail. This is because we process the requests on a 
concurrent
work queue and different threads may thus end up interacting with the same file.

Address the issue by using a static serial work queue for filesystem operations.

This might fix <rdar://156150166> though it is hard to confirm this is the root 
cause.

* Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:
(API::ContentRuleListStore::compileContentRuleListFile):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
(createMixedContentAutoUpgradeJsonRuleList):
(TEST_F(WKContentRuleListStoreTest, ConcurrentCompilations)):

Canonical link: https://commits.webkit.org/297757@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to