Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8f52c3b201776ea6135d3a0a793e876f93940c62
https://github.com/WebKit/WebKit/commit/8f52c3b201776ea6135d3a0a793e876f93940c62
Author: Ahmad Saleem <[email protected]>
Date: 2025-07-24 (Thu, 24 Jul 2025)
Changed paths:
R LayoutTests/fast/canvas/canvas-overloads-drawImageFromRect-expected.txt
R LayoutTests/fast/canvas/canvas-overloads-drawImageFromRect.html
R
LayoutTests/fast/canvas/drawImageFromRect_withToDataURLAsSource-expected.txt
R LayoutTests/fast/canvas/drawImageFromRect_withToDataURLAsSource.html
M LayoutTests/fast/canvas/image-object-in-canvas-expected.txt
M LayoutTests/fast/canvas/image-object-in-canvas.html
M LayoutTests/inspector/canvas/recording-2d-full-expected.txt
M LayoutTests/inspector/canvas/resources/recording-2d.js
M Source/WebCore/html/canvas/CanvasRenderingContext2D.idl
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h
M Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js
M Source/WebInspectorUI/UserInterface/Models/RecordingAction.js
M Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js
Log Message:
-----------
Remove non-standard legacy `drawImageFromRect` (CanvasDrawImage)
https://bugs.webkit.org/show_bug.cgi?id=284878
rdar://141681635
Reviewed by Kimmo Kinnunen.
This patch is to align WebKit with Gecko / Firefox and Blink / Chromium.
We have our current implementation based on standards (drawImage) so this patch
aims to get rid of legacy non-standard `drawImageFromRect`.
Blink removed this as well in 2014 in below commit:
Commit:
https://github.com/chromium/chromium/commit/ce07cefc396fdf4016e731b4e75592586785c6b0
>From MDN data, Safari / WebKit has supported standard alternatives since
>Safari 2,
so this is about time to try to get rid of non-standard legacy
`drawImageFromRect`.
* Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::drawImageFromRect): Deleted.
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:
* Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js:
* Source/WebInspectorUI/UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.prototype.getImageParameters):
* Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js:
(WI.RecordingActionTreeElement._classNameForAction):
* LayoutTests/fast/canvas/canvas-overloads-drawImageFromRect-expected.txt:
Removed.
* LayoutTests/fast/canvas/canvas-overloads-drawImageFromRect.html: Removed.
* LayoutTests/fast/canvas/drawImageFromRect_withToDataURLAsSource-expected.txt:
Removed.
* LayoutTests/fast/canvas/drawImageFromRect_withToDataURLAsSource.html: Removed.
* LayoutTests/fast/canvas/image-object-in-canvas-expected.txt:
* LayoutTests/fast/canvas/image-object-in-canvas.html:
* LayoutTests/inspector/canvas/resources/recording-2d.js:
* LayoutTests/inspector/canvas/recording-2d-full-expected.txt:
Canonical link: https://commits.webkit.org/297846@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
