Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c649ad2506b796c75577175f3757f004ed7372b
      
https://github.com/WebKit/WebKit/commit/5c649ad2506b796c75577175f3757f004ed7372b
  Author: Dana Estra <des...@apple.com>
  Date:   2025-07-25 (Fri, 25 Jul 2025)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css

  Log Message:
  -----------
  WebVTT line-height should be 'normal' by default
rdar://156633220
https://bugs.webkit.org/show_bug.cgi?id=296447

Reviewed by Tim Nguyen.

We set the default line height for all WebVTT to be 1 (100% of font size). But 
line-height
is not specified in the WebVTT spec, so should use the default css value 
'normal.' This has
been confirmed in a GitHub issue discussion: 
https://github.com/w3c/webvtt/issues/371#issuecomment-340157742
'5.33vh is only used for regions, not for cues, where line-height is simply the 
CSS default "normal",
which is typically about 1.2% larger.'

* Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:
(::cue):

Canonical link: https://commits.webkit.org/297860@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to