Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b1e5deb5bcdaf804514b00519e75a5d9affacb5e
https://github.com/WebKit/WebKit/commit/b1e5deb5bcdaf804514b00519e75a5d9affacb5e
Author: Sammy Gill <sammy.g...@apple.com>
Date: 2025-07-25 (Fri, 25 Jul 2025)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-column-rtl-direction-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-column-rtl-direction.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-column-vert-lr-rtl-wrap-reverse-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-column-vert-lr-rtl-wrap-reverse.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-column-vert-rl-rtl-wrap-reverse-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-column-vert-rl-rtl-wrap-reverse.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/multiline-align-self-expected.txt
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
Log Message:
-----------
[Flex] crossAxisDirection should take directionality into consideration
https://bugs.webkit.org/show_bug.cgi?id=296402
rdar://156540996
Reviewed by Alan Baradlay.
The goal of crossAxisDirection, as the name implies, is to map the
direction in which the flexbox's cross axis flows to a physical direction.
It correctly looks at flex-wrap since flex-wrap: wrap-reverse can flip
the direction of the cross axis.
However, there is an issue when the cross axis is in the same axis as
the flexbox's inline axis. In this case, the start and end of the inline
axis can be affected by the direction property. In those cases, we need
to look at which way the inline direction flows in order to determine
whether the cross axis is simply that direction or needs to be flipped
in the case of flex-wrap: wrap-reverse. This can be done by taking
writingMode().inlineDirection() instead of writingMode().blockDirection()
when the cross axis is in the inline axis and passing it into the switch
statement.
I also decided to move this function definition from the header to the
source since it is not clear to me why I decided to make it inline as I
do not think there is an obvious benefit that outweighs the - albeit
likely small - build time increase.
Canonical link: https://commits.webkit.org/297876@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
